tracing/tracing/metrics/system_health/power_metric.html - Issue 2293533002: Refactor NumericBuilder to HistogramBinBoundaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/system_health/power_metric.html

Issue 2293533002: Refactor NumericBuilder to HistogramBinBoundaries. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/metrics/system_health/power_metric.html

diff --git a/tracing/tracing/metrics/system_health/power_metric.html b/tracing/tracing/metrics/system_health/power_metric.html

index 4094af4df26e70d933e0f93ae845c02f48fbc4b2..844f5ac3728c486c32a844e9a29314b7dd464201 100644

--- a/tracing/tracing/metrics/system_health/power_metric.html

+++ b/tracing/tracing/metrics/system_health/power_metric.html

@@ -22,9 +22,10 @@ tr.exportTo('tr.metrics.sh', function() {

tr.v.UnitScale.Metric.NONE, tr.v.UnitScale.Metric.MILLI);

function energyConsumedPerFrame(valueList, model) {

- var frameEnergyConsumedInJ = tr.v.NumericBuilder.createLinear(

+ var frameEnergyConsumedInJ = new tr.v.Histogram(

tr.v.Unit.byName.energyInJoules_smallerIsBetter,

- tr.b.Range.fromExplicitRange(0, .5), 20).build();

+ tr.v.HistogramBinBoundaries.createLinear(0, 0.5, 20));

var frameStartTs = parseFloat(model.device.powerSeries.samples[0].start);

while (model.device.powerSeries.getSamplesWithinRange(

frameStartTs, frameStartTs + IDEAL_FRAME_DURATION_MS).length) {