Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: tracing/tracing/value/ui/scalar_span_test.html

Issue 2293533002: Refactor NumericBuilder to HistogramBinBoundaries. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/value/ui/scalar_span_test.html
diff --git a/tracing/tracing/value/ui/scalar_span_test.html b/tracing/tracing/value/ui/scalar_span_test.html
index 4966d9651d21d6dbe3bf6cd0728e523a65f5419b..7b98d6ea259d5746b1e7d15c6e83a11270a985c8 100644
--- a/tracing/tracing/value/ui/scalar_span_test.html
+++ b/tracing/tracing/value/ui/scalar_span_test.html
@@ -215,6 +215,7 @@ tr.b.unittest.testSuite(function() {
checkScalarSpan(this, 123.456789, Unit.byName.timeDurationInMs,
'123.457 ms');
checkScalarSpan(this, 0, Unit.byName.normalizedPercentage, '0.000%');
+ checkScalarSpan(this, 1, Unit.byName.normalizedPercentage, '100.000%');
checkScalarSpan(this, -2560, Unit.byName.sizeInBytes, '-2.5 KiB');
});
@@ -341,7 +342,7 @@ tr.b.unittest.testSuite(function() {
test('instantiate_withPercentage', function() {
var span = document.createElement('tr-v-ui-scalar-span');
- span.value = new ScalarNumeric(Unit.byName.unitlessNumber, 99);
+ span.value = new ScalarNumeric(Unit.byName.unitlessNumber, 0.99);
span.percentage = 0.66;
this.addHTMLOutput(span);
});
@@ -424,10 +425,8 @@ tr.b.unittest.testSuite(function() {
test('emptyNumeric', function() {
assert.strictEqual(tr.v.ui.createScalarSpan(), '');
- var numeric = tr.v.NumericBuilder.createLinear(
- tr.v.Unit.byName.timeDurationInMs, tr.b.Range.fromExplicitRange(0, 1000),
- 10).build();
- var value = new tr.v.NumericValue('foo', numeric);
+ var value = new tr.v.NumericValue(
+ 'foo', new tr.v.Histogram(tr.v.Unit.byName.count));
assert.strictEqual(tr.v.ui.createScalarSpan(value), '');
});
});
« no previous file with comments | « tracing/tracing/value/ui/related_value_set_span_test.html ('k') | tracing/tracing/value/ui/value_set_table_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698