Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: tracing/tracing/value/numeric.html

Issue 2293533002: Refactor NumericBuilder to HistogramBinBoundaries. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/histogram_test.html ('k') | tracing/tracing/value/ui/composition_span_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/numeric.html
diff --git a/tracing/tracing/value/numeric.html b/tracing/tracing/value/numeric.html
index 066693998560fea631bf72184d65da370ce2c9dc..e17bfa81f720d1423309c6671809ff52a8b3e8a2 100644
--- a/tracing/tracing/value/numeric.html
+++ b/tracing/tracing/value/numeric.html
@@ -27,7 +27,7 @@ tr.exportTo('tr.v', function() {
if (this.unit !== other.unit)
throw new Error('Merging Numerics with different units');
- // Two Numerics that were built using the same NumericBuilder
+ // Two Numerics that were built with the same boundaries
// can be merged using addNumeric().
if (this instanceof tr.v.Histogram && other instanceof tr.v.Histogram &&
this.canAddNumeric(other)) {
@@ -37,8 +37,8 @@ tr.exportTo('tr.v', function() {
}
// Either a Scalar and a Histogram, or two Scalars...
- // or two Numerics that were not built using the same NumericBuilder,
- // should be built from their raw samples.
+ // or two Numerics that were not built with the same boundaries should be
+ // built from their raw samples.
var samples = [];
this.sampleValuesInto(samples);
other.sampleValuesInto(samples);
« no previous file with comments | « tracing/tracing/value/histogram_test.html ('k') | tracing/tracing/value/ui/composition_span_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698