Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: tracing/tracing/value/value_set_test.html

Issue 2293533002: Refactor NumericBuilder to HistogramBinBoundaries. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/ui/value_set_view_test.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/value_set_test.html
diff --git a/tracing/tracing/value/value_set_test.html b/tracing/tracing/value/value_set_test.html
index 8063f97c856870458ba9b196560b6371f3526422..2f789027ad2b570cfa011cc974fc9be49c1b5db3 100644
--- a/tracing/tracing/value/value_set_test.html
+++ b/tracing/tracing/value/value_set_test.html
@@ -17,9 +17,7 @@ found in the LICENSE file.
tr.b.unittest.testSuite(function() {
test('addValuesFromDicts', function() {
- var n = tr.v.NumericBuilder.createLinear(
- tr.v.Unit.byName.timeDurationInMs, tr.b.Range.fromExplicitRange(0, 100),
- 100).build();
+ var n = new tr.v.Histogram(tr.v.Unit.byName.unitlessNumber);
n.add(10);
n.customizeSummaryOptions({
count: true,
@@ -39,9 +37,7 @@ tr.b.unittest.testSuite(function() {
});
test('addValueFromDictsWithSampleDiagnostic', function() {
- var n = tr.v.NumericBuilder.createLinear(
- tr.v.Unit.byName.timeDurationInMs, tr.b.Range.fromExplicitRange(0, 100),
- 100).build();
+ var n = new tr.v.Histogram(tr.v.Unit.byName.count);
n.add(10, tr.v.d.DiagnosticMap.fromObject({
bar: new tr.v.d.Generic('baz')
}));
@@ -59,9 +55,8 @@ tr.b.unittest.testSuite(function() {
});
test('computeSummaryValuesForNumericValue', function() {
- var n = tr.v.NumericBuilder.createLinear(
- tr.v.Unit.byName.timeDurationInMs, tr.b.Range.fromExplicitRange(0, 100),
- 100).build();
+ var n = new tr.v.Histogram(tr.v.Unit.byName.unitlessNumber,
+ tr.v.HistogramBinBoundaries.createLinear(0, 100, 100));
n.add(50);
n.add(60);
@@ -225,9 +220,7 @@ tr.b.unittest.testSuite(function() {
var unit = tr.v.Unit.byName.unitlessNumber;
var a = new tr.v.NumericValue('a', new tr.v.ScalarNumeric(unit, 1));
- var numeric = tr.v.NumericBuilder.createLinear(
- tr.v.Unit.byName.timeDurationInMs,
- tr.b.Range.fromExplicitRange(0, 1000), 10).build();
+ var numeric = new tr.v.Histogram(tr.v.Unit.byName.unitlessNumber);
numeric.add(1, tr.v.d.DiagnosticMap.fromObject({
rvs: new tr.v.d.RelatedValueSet([a])}));
var b = new tr.v.NumericValue('b', numeric);
« no previous file with comments | « tracing/tracing/value/ui/value_set_view_test.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698