Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: tracing/tracing/value/diagnostics/composition_test.html

Issue 2293533002: Refactor NumericBuilder to HistogramBinBoundaries. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/diagnostics/composition.html ('k') | tracing/tracing/value/histogram.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/diagnostics/composition_test.html
diff --git a/tracing/tracing/value/diagnostics/composition_test.html b/tracing/tracing/value/diagnostics/composition_test.html
index 8894e0155b40e956abe17c60fca521dabe6f7684..14ddd1a2d67a9a00297bf72cf28b959540ed1778 100644
--- a/tracing/tracing/value/diagnostics/composition_test.html
+++ b/tracing/tracing/value/diagnostics/composition_test.html
@@ -16,9 +16,7 @@ found in the LICENSE file.
'use strict';
tr.b.unittest.testSuite(function() {
- var TEST_NUMERIC_BUILDER = tr.v.NumericBuilder.createLinear(
- tr.v.Unit.byName.timeDurationInMs, tr.b.Range.fromExplicitRange(0, 10),
- 10);
+ var TEST_BOUNDARIES = tr.v.HistogramBinBoundaries.createLinear(0, 10, 10);
test('build', function() {
var values = new tr.v.ValueSet();
@@ -49,9 +47,11 @@ tr.b.unittest.testSuite(function() {
}
]);
+ var sampleForEvent = undefined;
var composition = tr.v.d.Composition.buildFromEvents(
- values, 'foo-', events, TEST_NUMERIC_BUILDER,
- tr.e.chrome.ChromeUserFriendlyCategoryDriver.fromEvent);
+ values, 'foo-', events,
+ tr.e.chrome.ChromeUserFriendlyCategoryDriver.fromEvent,
+ tr.v.Unit.byName.timeDurationInMs, sampleForEvent, TEST_BOUNDARIES);
assert.lengthOf(composition, 2);
var scriptValue = values.getValuesWithName('foo-script')[0];
« no previous file with comments | « tracing/tracing/value/diagnostics/composition.html ('k') | tracing/tracing/value/histogram.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698