Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Unified Diff: tracing/tracing/metrics/metric_registry_test.html

Issue 2293533002: Refactor NumericBuilder to HistogramBinBoundaries. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/metrics/cpu_process_metric_test.html ('k') | tracing/tracing/metrics/sample_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/metric_registry_test.html
diff --git a/tracing/tracing/metrics/metric_registry_test.html b/tracing/tracing/metrics/metric_registry_test.html
index 5534a776ed2672423a9035f47803e8db4f835bfe..715327c8ed06a28cc7833fdbacc19b11553f3dc4 100644
--- a/tracing/tracing/metrics/metric_registry_test.html
+++ b/tracing/tracing/metrics/metric_registry_test.html
@@ -14,22 +14,17 @@ found in the LICENSE file.
'use strict';
tr.b.unittest.testSuite(function() {
- var test_utils = tr.c.TestUtils;
- var ThreadSlice = tr.model.ThreadSlice;
- var NUMERIC_BUILDER = tr.v.NumericBuilder.createLinear(
- tr.v.Unit.byName.unitlessNumber, tr.b.Range.fromExplicitRange(0, 10), 10);
-
test('FindMetricByName', function() {
function sampleMetricA(values, model) {
- var n1 = NUMERIC_BUILDER.build();
+ var n1 = new tr.v.Histogram(tr.v.Unit.byName.count);
n1.add(1);
values.addValue(new tr.v.NumericValue('foo', n1));
}
tr.metrics.MetricRegistry.register(sampleMetricA);
function sampleMetricB(values, model) {
- var n1 = NUMERIC_BUILDER.build();
- var n2 = NUMERIC_BUILDER.build();
+ var n1 = new tr.v.Histogram(tr.v.Unit.byName.count);
+ var n2 = new tr.v.Histogram(tr.v.Unit.byName.count);
n1.add(1);
n2.add(2);
values.addValue(new tr.v.NumericValue('foo', n1));
@@ -38,9 +33,9 @@ tr.b.unittest.testSuite(function() {
tr.metrics.MetricRegistry.register(sampleMetricB);
function sampleMetricC(values, model) {
- var n1 = NUMERIC_BUILDER.build();
- var n2 = NUMERIC_BUILDER.build();
- var n3 = NUMERIC_BUILDER.build();
+ var n1 = new tr.v.Histogram(tr.v.Unit.byName.count);
+ var n2 = new tr.v.Histogram(tr.v.Unit.byName.count);
+ var n3 = new tr.v.Histogram(tr.v.Unit.byName.count);
n1.add(1);
n2.add(2);
n3.add(3);
@@ -50,7 +45,9 @@ tr.b.unittest.testSuite(function() {
}
tr.metrics.MetricRegistry.register(sampleMetricC);
- assert.isTrue(tr.metrics.MetricRegistry.findTypeInfoWithName('sampleMetricB').constructor === sampleMetricB); // @suppress longLineCheck
+ var typeInfo = tr.metrics.MetricRegistry.findTypeInfoWithName(
+ 'sampleMetricB');
+ assert.strictEqual(typeInfo.constructor, sampleMetricB);
});
test('registerNonFunctionThrows', function() {
« no previous file with comments | « tracing/tracing/metrics/cpu_process_metric_test.html ('k') | tracing/tracing/metrics/sample_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698