Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: tracing/tracing/metrics/system_health/rail_power_metric.html

Issue 2293533002: Refactor NumericBuilder to HistogramBinBoundaries. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/system_health/rail_power_metric.html
diff --git a/tracing/tracing/metrics/system_health/rail_power_metric.html b/tracing/tracing/metrics/system_health/rail_power_metric.html
index a388f0eacacd7fbe282f5f06b34bfe443bc7f398..6a9159fd654cf2315cad5faf0e3556529936ae92 100644
--- a/tracing/tracing/metrics/system_health/rail_power_metric.html
+++ b/tracing/tracing/metrics/system_health/rail_power_metric.html
@@ -16,18 +16,6 @@ found in the LICENSE file.
'use strict';
tr.exportTo('tr.metrics.sh', function() {
- var TIME_NUMERIC_BUILDER = tr.v.NumericBuilder.createExponential(
- tr.v.Unit.byName.timeDurationInMs_smallerIsBetter,
- tr.b.Range.fromExplicitRange(1e-3, 1e6), 50);
-
- var ENERGY_NUMERIC_BUILDER = tr.v.NumericBuilder.createExponential(
- tr.v.Unit.byName.energyInJoules_smallerIsBetter,
- tr.b.Range.fromExplicitRange(1e-3, 1e3), 50);
-
- var POWER_NUMERIC_BUILDER = tr.v.NumericBuilder.createExponential(
- tr.v.Unit.byName.powerInWatts_smallerIsBetter,
- tr.b.Range.fromExplicitRange(1e-3, 1e3), 50);
-
function railPowerMetricHelper(values, model) {
var railStageTimes = new Map();
var railStageEnergy = new Map();
@@ -54,21 +42,24 @@ tr.exportTo('tr.metrics.sh', function() {
tr.v.UnitScale.Metric.MILLI, tr.v.UnitScale.Metric.NONE);
var powerInW = energyInJ / durationInS;
- var durationHist = TIME_NUMERIC_BUILDER.build();
+ var durationHist = new tr.v.Histogram(
+ tr.v.Unit.byName.timeDurationInMs_smallerIsBetter);
durationHist.add(durationInMs);
values.addValue(new tr.v.NumericValue('total_time_' + title, durationHist,
{description: 'Time spent in RAIL stage ' + title}));
- var energyHist = ENERGY_NUMERIC_BUILDER.build();
+ var energyHist = new tr.v.Histogram(
+ tr.v.Unit.byName.energyInJoules_smallerIsBetter);
energyHist.add(energyInJ);
values.addValue(new tr.v.NumericValue('total_energy_' + title, energyHist,
{description: 'Energy consumed in RAIL stage ' + title}));
- var powerHist = POWER_NUMERIC_BUILDER.build();
+ var powerHist = new tr.v.Histogram(
+ tr.v.Unit.byName.powerInWatts_smallerIsBetter);
powerHist.add(powerInW);
values.addValue(new tr.v.NumericValue('energy_consumption_rate_' + title,
- powerHist,
- {description: 'Energy consumption rate for RAIL stage ' + title}));
+ powerHist, {description: 'Energy consumption rate for RAIL stage ' +
+ title}));
}
}

Powered by Google App Engine
This is Rietveld 408576698