Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: tracing/tracing/metrics/system_health/responsiveness_metric.html

Issue 2293533002: Refactor NumericBuilder to HistogramBinBoundaries. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/system_health/responsiveness_metric.html
diff --git a/tracing/tracing/metrics/system_health/responsiveness_metric.html b/tracing/tracing/metrics/system_health/responsiveness_metric.html
index 36d336ec1435ae7eaae68cf01f0d23b80ada4fc4..45a2424b522153cec4123ba7988b675bdc2bf4e8 100644
--- a/tracing/tracing/metrics/system_health/responsiveness_metric.html
+++ b/tracing/tracing/metrics/system_health/responsiveness_metric.html
@@ -54,36 +54,25 @@ tr.exportTo('tr.metrics.sh', function() {
return tr.b.Statistics.timestampsDiscrepancy(frameTimestamps, absolute);
}
- var RESPONSE_NUMERIC_BUILDER = tr.v.NumericBuilder.createLinear(
- tr.v.Unit.byName.timeDurationInMs_smallerIsBetter,
- tr.b.Range.fromExplicitRange(100, 1000), 90);
-
- var THROUGHPUT_NUMERIC_BUILDER = tr.v.NumericBuilder.createLinear(
- tr.v.Unit.byName.unitlessNumber_biggerIsBetter,
- tr.b.Range.fromExplicitRange(10, 60), 10);
-
- var DISCREPANCY_NUMERIC_BUILDER = new tr.v.NumericBuilder(
- tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, 0)
- .addLinearBins(1000, 50) // 20ms step to 1s
- .addExponentialBins(10000, 10);
-
- var LATENCY_NUMERIC_BUILDER = tr.v.NumericBuilder.createLinear(
- tr.v.Unit.byName.timeDurationInMs_smallerIsBetter,
- tr.b.Range.fromExplicitRange(0, 300), 60);
-
/**
* @param {!tr.v.ValueSet} values
* @param {!tr.model.Model} model
* @param {!Object=} opt_options
*/
function responsivenessMetric(values, model, opt_options) {
- // TODO(benjhayden): Add categories to benchmark to support:
- // tr.metrics.sh.loadingMetric(values, model);
-
- var responseNumeric = RESPONSE_NUMERIC_BUILDER.build();
- var throughputNumeric = THROUGHPUT_NUMERIC_BUILDER.build();
- var frameTimeDiscrepancyNumeric = DISCREPANCY_NUMERIC_BUILDER.build();
- var latencyNumeric = LATENCY_NUMERIC_BUILDER.build();
+ var responseNumeric = new tr.v.Histogram(
+ tr.v.Unit.byName.timeDurationInMs_smallerIsBetter,
+ tr.v.HistogramBinBoundaries.createLinear(100, 1e3, 50));
+ var throughputNumeric = new tr.v.Histogram(
+ tr.v.Unit.byName.unitlessNumber_biggerIsBetter,
+ tr.v.HistogramBinBoundaries.createLinear(10, 60, 10));
+ var frameTimeDiscrepancyNumeric = new tr.v.Histogram(
+ tr.v.Unit.byName.timeDurationInMs_smallerIsBetter,
+ tr.v.HistogramBinBoundaries.createLinear(0, 1e3, 50).
+ addExponentialBins(1e4, 10));
+ var latencyNumeric = new tr.v.Histogram(
+ tr.v.Unit.byName.timeDurationInMs_smallerIsBetter,
+ tr.v.HistogramBinBoundaries.createLinear(0, 300, 60));
model.userModel.expectations.forEach(function(ue) {
if (opt_options && opt_options.rangeOfInterest &&

Powered by Google App Engine
This is Rietveld 408576698