Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tracing/tracing/metrics/system_health/loading_metric.html

Issue 2293533002: Refactor NumericBuilder to HistogramBinBoundaries. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/metrics/system_health/hazard_metric.html ('k') | tracing/tracing/metrics/system_health/long_tasks_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/system_health/loading_metric.html
diff --git a/tracing/tracing/metrics/system_health/loading_metric.html b/tracing/tracing/metrics/system_health/loading_metric.html
index 5c00041610bad8298abcf5883c3838defe906411..97a99787f955834cc59d97c65c4b4e0044031339 100644
--- a/tracing/tracing/metrics/system_health/loading_metric.html
+++ b/tracing/tracing/metrics/system_health/loading_metric.html
@@ -122,13 +122,14 @@ tr.exportTo('tr.metrics.sh', function() {
}
};
- var FIRST_PAINT_NUMERIC_BUILDER =
- new tr.v.NumericBuilder(timeDurationInMs_smallerIsBetter, 0)
- .addLinearBins(1000, 20) // 50ms step to 1s
- .addLinearBins(3000, 20) // 100ms step to 3s
- .addExponentialBins(20000, 20);
+ var FIRST_PAINT_BOUNDARIES = tr.v.HistogramBinBoundaries
+ .createLinear(0, 1e3, 20) // 50ms step to 1s
+ .addLinearBins(3e3, 20) // 100ms step to 3s
+ .addExponentialBins(20e3, 20);
+
function createHistogram() {
- var histogram = FIRST_PAINT_NUMERIC_BUILDER.build();
+ var histogram = new tr.v.Histogram(
+ timeDurationInMs_smallerIsBetter, FIRST_PAINT_BOUNDARIES);
histogram.customizeSummaryOptions({
avg: true,
count: false,
« no previous file with comments | « tracing/tracing/metrics/system_health/hazard_metric.html ('k') | tracing/tracing/metrics/system_health/long_tasks_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698