Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. (Closed)

Created:
7 years, 6 months ago by dcheng
Modified:
7 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, asanka, David Black, skanuj+watch_chromium.org, tburkard+watch_chromium.org, tzik+watch_chromium.org, dougw+watch_chromium.org, mad+watch_chromium.org, rginda+watch_chromium.org, kinuko+watch, markusheintz_, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, benjhayden+dwatch_chromium.org, jam, joi+watch-content_chromium.org, shishir+watch_chromium.org, darin-cc_chromium.org, dhollowa+watch_chromium.org, chromium-apps-reviews_chromium.org, tim (not reviewing), dbeam+watch-options_chromium.org, kkania, Raghu Simha, gavinp+prer_chromium.org, jfweitz+watch_chromium.org, haitaol1, Jered, akalin, tfarina, donnd+watch_chromium.org, frankf, dominich, dominich+watch_chromium.org, robertshield, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on Linux in the chrome/ directory. BUG=173286 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205866

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -210 lines) Patch
M chrome/browser/automation/automation_event_queue.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/background/background_application_list_model.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/character_encoding.cc View 1 chunk +1 line, -4 lines 2 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_history.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/download/download_history_unittest.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_rule.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_condition.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket_api.cc View 12 chunks +13 lines, -31 lines 0 comments Download
M chrome/browser/extensions/api/web_request/form_data_parser_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_sync_bundle.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_function.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_sync_bundle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 1 chunk +14 lines, -16 lines 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/test_extension_prefs.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/google_apis/drive_api_parser.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/google_apis/drive_api_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/google_apis/gdata_wapi_parser.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/icon_loader.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/net/dns_probe_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/dns_probe_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/predictor.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/net/sqlite_server_bound_cert_store.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/notifications/balloon_notification_ui_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/database_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_cache.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/sync/glue/shared_change_processor_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/translate/translate_manager_metrics_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/gtk/custom_button.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/search/instant_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_controller_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/search/instant_loader.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings_unittest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/startup_pages_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/value_store/value_store_frontend_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/user_script_slave.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/renderer/translate/translate_helper_metrics_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/performance_logger_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dcheng
7 years, 6 months ago (2013-06-12 03:46:09 UTC) #1
Nico
lgtm So cool :-) https://codereview.chromium.org/16703018/diff/1/chrome/browser/character_encoding.cc File chrome/browser/character_encoding.cc (right): https://codereview.chromium.org/16703018/diff/1/chrome/browser/character_encoding.cc#newcode110 chrome/browser/character_encoding.cc:110: CanonicalEncodingMap() {} Maybe delete this ...
7 years, 6 months ago (2013-06-12 04:42:27 UTC) #2
dcheng
https://codereview.chromium.org/16703018/diff/1/chrome/browser/character_encoding.cc File chrome/browser/character_encoding.cc (right): https://codereview.chromium.org/16703018/diff/1/chrome/browser/character_encoding.cc#newcode110 chrome/browser/character_encoding.cc:110: CanonicalEncodingMap() {} On 2013/06/12 04:42:27, Nico wrote: > Maybe ...
7 years, 6 months ago (2013-06-12 12:01:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/16703018/1
7 years, 6 months ago (2013-06-12 12:01:37 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 17:59:15 UTC) #5
Message was sent while issue was closed. 
Change committed as 205866

Powered by Google App Engine
This is Rietveld 408576698