Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: chrome/browser/character_encoding.cc

Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/character_encoding.cc
diff --git a/chrome/browser/character_encoding.cc b/chrome/browser/character_encoding.cc
index a82f3dca7b2636ec10446497ef3be43521de6675..9a0f1122f5927a18ac81995760a7a4420eb62b4b 100644
--- a/chrome/browser/character_encoding.cc
+++ b/chrome/browser/character_encoding.cc
@@ -107,10 +107,7 @@ typedef std::map<std::string, const char*> CanonicalNameDisplayNameMapType;
class CanonicalEncodingMap {
public:
- CanonicalEncodingMap()
- : id_to_encoding_name_map_(NULL),
- encoding_name_to_id_map_(NULL),
- encoding_name_to_display_name_map_(NULL) { }
+ CanonicalEncodingMap() {}
Nico 2013/06/12 04:42:27 Maybe delete this completely?
dcheng 2013/06/12 12:01:27 We can't, due to the DISALLOW_COPY_AND_ASSIGN macr
const IdToCanonicalEncodingNameMapType* GetIdToCanonicalEncodingNameMapData();
const CanonicalEncodingNameToIdMapType* GetCanonicalEncodingNameToIdMapData();
const CanonicalNameDisplayNameMapType* GetCanonicalNameDisplayNameMapData();

Powered by Google App Engine
This is Rietveld 408576698