chrome/browser/extensions/api/web_request/form_data_parser_unittest.cc - Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/form_data_parser_unittest.cc

Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/character_encoding.cc ('K') | « chrome/browser/extensions/api/socket/socket_api.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/form_data_parser_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/form_data_parser_unittest.cc b/chrome/browser/extensions/api/web_request/form_data_parser_unittest.cc

index e3012dbd3498758ee1e5b3ae352f39d2bab33d38..d6cf7155ade3f6bd7815b6ef46321f0785185a13 100644

--- a/chrome/browser/extensions/api/web_request/form_data_parser_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/form_data_parser_unittest.cc

@@ -17,12 +17,12 @@ scoped_ptr<FormDataParser> InitParser(

const std::string& content_type_header,

std::vector<std::string>* output) {

if (output == NULL)

- return scoped_ptr<FormDataParser>(NULL);

+ return scoped_ptr<FormDataParser>();

output->clear();

scoped_ptr<FormDataParser> parser(

FormDataParser::CreateFromContentTypeHeader(&content_type_header));

if (parser.get() == NULL)

- return scoped_ptr<FormDataParser>(NULL);

+ return scoped_ptr<FormDataParser>();

return parser.Pass();

}