chrome/browser/net/dns_probe_service.cc - Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/dns_probe_service.cc

Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/dns_probe_service.cc

diff --git a/chrome/browser/net/dns_probe_service.cc b/chrome/browser/net/dns_probe_service.cc

index 8a0e9f073e973e6581e7c11a1924c5d5760cf34c..156313f796c4e1f560b8b4235bc30737c66c71aa 100644

--- a/chrome/browser/net/dns_probe_service.cc

+++ b/chrome/browser/net/dns_probe_service.cc

@@ -275,7 +275,7 @@ scoped_ptr<DnsProbeJob> DnsProbeService::CreateProbeJob(

const DnsConfig& dns_config,

const DnsProbeJob::CallbackType& job_callback) {

if (!dns_config.IsValid())

- return scoped_ptr<DnsProbeJob>(NULL);

+ return scoped_ptr<DnsProbeJob>();

scoped_ptr<DnsClient> dns_client(DnsClient::CreateClient(NULL));

dns_client->SetConfig(dns_config);