chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc - Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/character_encoding.cc ('K') | « chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc ('k') | chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

index ebcf75c637ae4a5bf068befe64f6ee70a6106b22..e99d63f5101a9b484e039ad5ada5dc1b47919d21 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

@@ -350,7 +350,7 @@ scoped_ptr<DictionaryValue> GetDictionaryFromArray(

Value* entry = NULL;

ListValue* list = NULL;

if (!dictionary->GetWithoutPathExpansion(*name, &entry))

- return scoped_ptr<DictionaryValue>(NULL);

+ return scoped_ptr<DictionaryValue>();

switch (entry->GetType()) {

case Value::TYPE_STRING: // Replace the present string with a list.

list = new ListValue;

@@ -366,7 +366,7 @@ scoped_ptr<DictionaryValue> GetDictionaryFromArray(

break;

default:

NOTREACHED(); // We never put other Values here.

- return scoped_ptr<DictionaryValue>(NULL);

+ return scoped_ptr<DictionaryValue>();

}

} else {

dictionary->SetString(*name, *value);