chrome/browser/net/dns_probe_service_unittest.cc - Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/dns_probe_service_unittest.cc

Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/dns_probe_service_unittest.cc

diff --git a/chrome/browser/net/dns_probe_service_unittest.cc b/chrome/browser/net/dns_probe_service_unittest.cc

index 108332a3949daa95c7a4d0826e9e1ba19bf46da5..15cbb440aee1b3eb3c38a93ca691224c898102e1 100644

--- a/chrome/browser/net/dns_probe_service_unittest.cc

+++ b/chrome/browser/net/dns_probe_service_unittest.cc

@@ -88,7 +88,7 @@ class TestDnsProbeService : public DnsProbeService {

virtual scoped_ptr<DnsProbeJob> CreateSystemProbeJob(

const DnsProbeJob::CallbackType& job_callback) OVERRIDE {

if (mock_system_fail_)

- return scoped_ptr<DnsProbeJob>(NULL);

+ return scoped_ptr<DnsProbeJob>();

system_job_created_ = true;

return scoped_ptr<DnsProbeJob>(