chrome/renderer/translate/translate_helper_metrics_unittest.cc - Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/translate/translate_helper_metrics_unittest.cc

Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/translate/translate_helper_metrics_unittest.cc

diff --git a/chrome/renderer/translate/translate_helper_metrics_unittest.cc b/chrome/renderer/translate/translate_helper_metrics_unittest.cc

index 4434e2476f40439c2db844227737978d6759106d..1ac438aed6377e724b8f2ac703eb5650ad1cbdf0 100644

--- a/chrome/renderer/translate/translate_helper_metrics_unittest.cc

+++ b/chrome/renderer/translate/translate_helper_metrics_unittest.cc

@@ -25,10 +25,7 @@ const int kFalse = 0;

class MetricsRecorder {

public:

- explicit MetricsRecorder(const char* key)

- : key_(key),

- base_samples_(NULL),

- samples_(NULL) {

+ explicit MetricsRecorder(const char* key) : key_(key) {

StatisticsRecorder::Initialize();

HistogramBase* histogram = StatisticsRecorder::FindHistogram(key_);