Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2913)

Unified Diff: chrome/test/chromedriver/chrome/performance_logger_unittest.cc

Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/performance_logger_unittest.cc
diff --git a/chrome/test/chromedriver/chrome/performance_logger_unittest.cc b/chrome/test/chromedriver/chrome/performance_logger_unittest.cc
index 8f655b0395d9a614693010a013102369da7979c2..a3a36277a853ab87f8432171a6ce9ded5173e291 100644
--- a/chrome/test/chromedriver/chrome/performance_logger_unittest.cc
+++ b/chrome/test/chromedriver/chrome/performance_logger_unittest.cc
@@ -103,13 +103,13 @@ scoped_ptr<DictionaryValue> ParseDictionary(const std::string& json) {
SCOPED_TRACE(json.c_str());
SCOPED_TRACE(error.c_str());
ADD_FAILURE();
- return scoped_ptr<DictionaryValue>(NULL);
+ return scoped_ptr<DictionaryValue>();
}
DictionaryValue* dict = NULL;
if (!value->GetAsDictionary(&dict)) {
SCOPED_TRACE("JSON object is not a dictionary");
ADD_FAILURE();
- return scoped_ptr<DictionaryValue>(NULL);
+ return scoped_ptr<DictionaryValue>();
}
return scoped_ptr<DictionaryValue>(dict->DeepCopy());
}

Powered by Google App Engine
This is Rietveld 408576698