Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Unified Diff: chrome/browser/extensions/api/socket/socket_api.cc

Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/socket/socket_api.cc
diff --git a/chrome/browser/extensions/api/socket/socket_api.cc b/chrome/browser/extensions/api/socket/socket_api.cc
index 64a5b5afb911704930a3bba29e9daaeba1d9c1f1..b5f781d7ca9464ac1b7f1cc53f1c3e7a19ae158b 100644
--- a/chrome/browser/extensions/api/socket/socket_api.cc
+++ b/chrome/browser/extensions/api/socket/socket_api.cc
@@ -288,9 +288,7 @@ void SocketBindFunction::Work() {
SetResult(Value::CreateIntegerValue(result));
}
-SocketListenFunction::SocketListenFunction()
- : params_(NULL) {
-}
+SocketListenFunction::SocketListenFunction() {}
SocketListenFunction::~SocketListenFunction() {}
@@ -328,9 +326,7 @@ void SocketListenFunction::Work() {
SetResult(Value::CreateIntegerValue(result));
}
-SocketAcceptFunction::SocketAcceptFunction()
- : params_(NULL) {
-}
+SocketAcceptFunction::SocketAcceptFunction() {}
SocketAcceptFunction::~SocketAcceptFunction() {}
@@ -363,9 +359,7 @@ void SocketAcceptFunction::OnAccept(int result_code,
AsyncWorkCompleted();
}
-SocketReadFunction::SocketReadFunction()
- : params_(NULL) {
-}
+SocketReadFunction::SocketReadFunction() {}
SocketReadFunction::~SocketReadFunction() {}
@@ -442,9 +436,7 @@ void SocketWriteFunction::OnCompleted(int bytes_written) {
AsyncWorkCompleted();
}
-SocketRecvFromFunction::SocketRecvFromFunction()
- : params_(NULL) {
-}
+SocketRecvFromFunction::SocketRecvFromFunction() {}
SocketRecvFromFunction::~SocketRecvFromFunction() {}
@@ -556,9 +548,7 @@ void SocketSendToFunction::OnCompleted(int bytes_written) {
AsyncWorkCompleted();
}
-SocketSetKeepAliveFunction::SocketSetKeepAliveFunction()
- : params_(NULL) {
-}
+SocketSetKeepAliveFunction::SocketSetKeepAliveFunction() {}
SocketSetKeepAliveFunction::~SocketSetKeepAliveFunction() {}
@@ -582,9 +572,7 @@ void SocketSetKeepAliveFunction::Work() {
SetResult(Value::CreateBooleanValue(result));
}
-SocketSetNoDelayFunction::SocketSetNoDelayFunction()
- : params_(NULL) {
-}
+SocketSetNoDelayFunction::SocketSetNoDelayFunction() {}
SocketSetNoDelayFunction::~SocketSetNoDelayFunction() {}
@@ -604,8 +592,7 @@ void SocketSetNoDelayFunction::Work() {
SetResult(Value::CreateBooleanValue(result));
}
-SocketGetInfoFunction::SocketGetInfoFunction()
- : params_(NULL) {}
+SocketGetInfoFunction::SocketGetInfoFunction() {}
SocketGetInfoFunction::~SocketGetInfoFunction() {}
@@ -699,8 +686,7 @@ void SocketGetNetworkListFunction::SendResponseOnUIThread(
SendResponse(true);
}
-SocketJoinGroupFunction::SocketJoinGroupFunction()
- : params_(NULL) {}
+SocketJoinGroupFunction::SocketJoinGroupFunction() {}
SocketJoinGroupFunction::~SocketJoinGroupFunction() {}
@@ -744,9 +730,7 @@ void SocketJoinGroupFunction::Work() {
SetResult(Value::CreateIntegerValue(result));
}
-
-SocketLeaveGroupFunction::SocketLeaveGroupFunction()
- : params_(NULL) {}
+SocketLeaveGroupFunction::SocketLeaveGroupFunction() {}
SocketLeaveGroupFunction::~SocketLeaveGroupFunction() {}
@@ -790,8 +774,7 @@ void SocketLeaveGroupFunction::Work() {
SetResult(Value::CreateIntegerValue(result));
}
-SocketSetMulticastTimeToLiveFunction::SocketSetMulticastTimeToLiveFunction()
- : params_(NULL) {}
+SocketSetMulticastTimeToLiveFunction::SocketSetMulticastTimeToLiveFunction() {}
SocketSetMulticastTimeToLiveFunction::~SocketSetMulticastTimeToLiveFunction() {}
@@ -822,8 +805,8 @@ void SocketSetMulticastTimeToLiveFunction::Work() {
SetResult(Value::CreateIntegerValue(result));
}
-SocketSetMulticastLoopbackModeFunction::SocketSetMulticastLoopbackModeFunction()
- : params_(NULL) {}
+SocketSetMulticastLoopbackModeFunction::
+ SocketSetMulticastLoopbackModeFunction() {}
SocketSetMulticastLoopbackModeFunction::
~SocketSetMulticastLoopbackModeFunction() {}
@@ -856,8 +839,7 @@ void SocketSetMulticastLoopbackModeFunction::Work() {
SetResult(Value::CreateIntegerValue(result));
}
-SocketGetJoinedGroupsFunction::SocketGetJoinedGroupsFunction()
- : params_(NULL) {}
+SocketGetJoinedGroupsFunction::SocketGetJoinedGroupsFunction() {}
SocketGetJoinedGroupsFunction::~SocketGetJoinedGroupsFunction() {}

Powered by Google App Engine
This is Rietveld 408576698