chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc - Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc

Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/character_encoding.cc ('K') | « chrome/browser/ui/webui/options/startup_pages_handler.cc ('k') | chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc

diff --git a/chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc b/chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc

index 4f9c71e107766de6babdd49fd820f889aa177388..2e8a9c12df8887da26bad482cd55244515a7b4ef 100644

--- a/chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc

+++ b/chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc

@@ -172,7 +172,7 @@ scoped_ptr<VectorOfMetricVectors> AggregateMetric(

const base::TimeDelta& resolution,

AggregationMethod method) {

if (!metrics || intervals.empty())

- return scoped_ptr<VectorOfMetricVectors>(NULL);

+ return scoped_ptr<VectorOfMetricVectors>();

CHECK(resolution > base::TimeDelta());

@@ -188,7 +188,7 @@ scoped_ptr<VectorOfMetricVectors> AggregateMetric(

type, metrics, start, intervals, resolution);

default:

NOTREACHED();

- return scoped_ptr<VectorOfMetricVectors>(NULL);

+ return scoped_ptr<VectorOfMetricVectors>();

}