chrome/browser/extensions/api/webstore_private/webstore_private_api.cc - Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 16703018: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/character_encoding.cc ('K') | « chrome/browser/extensions/api/web_request/form_data_parser_unittest.cc ('k') | chrome/browser/extensions/app_sync_bundle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

index 3130fd3aa0e6ddd6de8b3a36ccd1f1910cad3c34..c77121ce9c05e37557e914a94b75ad1d65339dcb 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

@@ -86,7 +86,7 @@ scoped_ptr<WebstoreInstaller::Approval> PendingApprovals::PopApproval(

return scoped_ptr<WebstoreInstaller::Approval>(approval);

}

- return scoped_ptr<WebstoreInstaller::Approval>(NULL);

+ return scoped_ptr<WebstoreInstaller::Approval>();

}

// Uniquely holds the profile and extension id of an install between the time we