GPU: Build most of the gpu as a single DLL.

GPU: Build most of the gpu as a single DLL.

BUG=114261
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124983

[rvargas (doing something else), 2012-03-03 00:08:23]

I had to revert the previous patch so... patch set 1 is what you guys already
reviewed.

Please take another look.

[brettw, 2012-03-05 18:26:45]

PPAPI LGTM rubber stamp

[apatrick_chromium, 2012-03-05 19:56:12]

lgtm

[vangelis, 2012-03-06 21:56:49]

On 2012/03/05 19:56:12, apatrick_chromium wrote:
> lgtm

rvargas: it looks like this change possibly broke the incremental build on
windows. On a completely clean build I now get:

1>.\command_buffer\common\cmd_buffer_common.cc(38) : error C2220: warning
treated as error - no 'object' file generated
1>.\command_buffer\common\cmd_buffer_common.cc(38) : warning C4273:
'gpu::CommandBuffer::GetLastError' : inconsistent dll linkage
1>       
d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/command_buffer.h(142)
: see previous definition of 'GetLastError'
1>.\command_buffer\common\id_allocator.cc(12) : error C2220: warning treated as
error - no 'object' file generated
1>.\command_buffer\common\id_allocator.cc(12) : warning C4273:
'gpu::IdAllocatorInterface::~IdAllocatorInterface' : inconsistent dll linkage
1>       
d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(27) :
see previous definition of '{dtor}'
1>.\command_buffer\common\id_allocator.cc(15) : warning C4273:
'gpu::IdAllocator::IdAllocator' : inconsistent dll linkage
1>       
d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(49) :
see previous definition of '{ctor}'
1>.\command_buffer\common\id_allocator.cc(17) : warning C4273:
'gpu::IdAllocator::~IdAllocator' : inconsistent dll linkage
1>       
d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(50) :
see previous definition of '{dtor}'
1>.\command_buffer\common\id_allocator.cc(19) : warning C4273:
'gpu::IdAllocator::AllocateID' : inconsistent dll linkage
1>       
d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(53) :
see previous definition of 'AllocateID'
1>.\command_buffer\common\id_allocator.cc(35) : warning C4273:
'gpu::IdAllocator::AllocateIDAtOrAbove' : inconsistent dll linkage
1>       
d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(54) :
see previous definition of 'AllocateIDAtOrAbove'
1>.\command_buffer\common\id_allocator.cc(53) : warning C4273:
'gpu::IdAllocator::MarkAsUsed' : inconsistent dll linkage
1>       
d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(55) :
see previous definition of 'MarkAsUsed'
1>.\command_buffer\common\id_allocator.cc(60) : warning C4273:
'gpu::IdAllocator::FreeID' : inconsistent dll linkage
1>       
d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(56) :
see previous definition of 'FreeID'
1>.\command_buffer\common\id_allocator.cc(67) : warning C4273:
'gpu::IdAllocator::InUse' : inconsistent dll linkage
1>       
d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(57) :
see previous definition of 'InUse'
1>.\command_buffer\common\id_allocator.cc(71) : warning C4273:
'gpu::IdAllocator::LastUsedId' : inconsistent dll linkage
1>       
d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(64) :
see previous definition of 'LastUsedId'
1>.\command_buffer\common\id_allocator.cc(79) : warning C4273:
'gpu::IdAllocator::FindFirstUnusedId' : inconsistent dll linkage
1>       
d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(67) :
see previous definition of 'FindFirstUnusedId'

...

[rvargas (doing something else), 2012-03-06 22:27:24]

The errors are consistent with an incremental compile across this change. Did
you clobber your solution? You are saying that this is a clean build, but the
errors don't agree.

On 2012/03/06 21:56:49, vangelis wrote:
> On 2012/03/05 19:56:12, apatrick_chromium wrote:
> > lgtm
> 
> rvargas: it looks like this change possibly broke the incremental build on
> windows. On a completely clean build I now get:
> 
> 1>.\command_buffer\common\cmd_buffer_common.cc(38) : error C2220: warning
> treated as error - no 'object' file generated
> 1>.\command_buffer\common\cmd_buffer_common.cc(38) : warning C4273:
> 'gpu::CommandBuffer::GetLastError' : inconsistent dll linkage
> 1>       
>
d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/command_buffer.h(142)
> : see previous definition of 'GetLastError'
> 1>.\command_buffer\common\id_allocator.cc(12) : error C2220: warning treated
as
> error - no 'object' file generated
> 1>.\command_buffer\common\id_allocator.cc(12) : warning C4273:
> 'gpu::IdAllocatorInterface::~IdAllocatorInterface' : inconsistent dll linkage
> 1>       
> d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(27)
:
> see previous definition of '{dtor}'
> 1>.\command_buffer\common\id_allocator.cc(15) : warning C4273:
> 'gpu::IdAllocator::IdAllocator' : inconsistent dll linkage
> 1>       
> d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(49)
:
> see previous definition of '{ctor}'
> 1>.\command_buffer\common\id_allocator.cc(17) : warning C4273:
> 'gpu::IdAllocator::~IdAllocator' : inconsistent dll linkage
> 1>       
> d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(50)
:
> see previous definition of '{dtor}'
> 1>.\command_buffer\common\id_allocator.cc(19) : warning C4273:
> 'gpu::IdAllocator::AllocateID' : inconsistent dll linkage
> 1>       
> d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(53)
:
> see previous definition of 'AllocateID'
> 1>.\command_buffer\common\id_allocator.cc(35) : warning C4273:
> 'gpu::IdAllocator::AllocateIDAtOrAbove' : inconsistent dll linkage
> 1>       
> d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(54)
:
> see previous definition of 'AllocateIDAtOrAbove'
> 1>.\command_buffer\common\id_allocator.cc(53) : warning C4273:
> 'gpu::IdAllocator::MarkAsUsed' : inconsistent dll linkage
> 1>       
> d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(55)
:
> see previous definition of 'MarkAsUsed'
> 1>.\command_buffer\common\id_allocator.cc(60) : warning C4273:
> 'gpu::IdAllocator::FreeID' : inconsistent dll linkage
> 1>       
> d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(56)
:
> see previous definition of 'FreeID'
> 1>.\command_buffer\common\id_allocator.cc(67) : warning C4273:
> 'gpu::IdAllocator::InUse' : inconsistent dll linkage
> 1>       
> d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(57)
:
> see previous definition of 'InUse'
> 1>.\command_buffer\common\id_allocator.cc(71) : warning C4273:
> 'gpu::IdAllocator::LastUsedId' : inconsistent dll linkage
> 1>       
> d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(64)
:
> see previous definition of 'LastUsedId'
> 1>.\command_buffer\common\id_allocator.cc(79) : warning C4273:
> 'gpu::IdAllocator::FindFirstUnusedId' : inconsistent dll linkage
> 1>       
> d:\src\chrome-svn-8\src\gpu\command_buffer\common\../common/id_allocator.h(67)
:
> see previous definition of 'FindFirstUnusedId'
> 
> ...

[Nico, 2012-03-08 18:54:21]

gles2_c_lib is missing a dependency on command_buffer_client, since
GLES2AttachShader and friends use gpu::CommandBufferHelper::GetSpace(unsigned
int). This breaks the work-in-progress components build on mac. I'll send you a
CL.