Remove windowName from CRWSessionController.

Remove windowName from CRWSessionController.

The windowName parameter passed during the Tab creation was always
nil (either directly passed as nil or forwarded from the caller)
except during unit tests.

Remove the property from CRWSessionController and convert the unit
tests to no longer set this parameter (instead comparing the object
directly) and remove the parameter from all methods taking windowName.

Re-order some parameter in initialiser to put more important
parameter first (e.g. -initWithBrowserState:openedByDOM versus
-initWithOpenedByDOM:browserState:).

BUG=620465
Review-Url: https://codereview.chromium.org/2720983002
Cr-Commit-Position: refs/heads/master@{#453786}
Committed: https://chromium.googlesource.com/chromium/src/+/a6395911b0dc6cad281c0e13c62578689be02b93

[sdefresne, 2017-02-28 05:47:20]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 05:47:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-02-28 05:47:52]

sdefresne@chromium.org changed reviewers:
+ eugenebut@chromium.org, rohitrao@chromium.org

[sdefresne, 2017-02-28 05:47:53]

eugenebut: please take a look at ios/web
rohitrao: please take a look at the rest

[commit-bot: I haz the power, 2017-02-28 06:40:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 06:40:10]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-02-28 16:04:09]

lgtm

https://codereview.chromium.org/2720983002/diff/1/ios/chrome/browser/tabs/tab.h
File ios/chrome/browser/tabs/tab.h (right):

https://codereview.chromium.org/2720983002/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab.h:187: // -initWithBrowserState:opener:model.
initWithBrowserState:opener:openedByDOM:model: ?

https://codereview.chromium.org/2720983002/diff/1/ios/chrome/browser/tabs/tab...
File ios/chrome/browser/tabs/tab_model_unittest.mm (right):

https://codereview.chromium.org/2720983002/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab_model_unittest.mm:190: [window
Optional nit: Do you want to create local session_storage variable to improve
the formatting?

https://codereview.chromium.org/2720983002/diff/1/ios/web/web_state/web_state...
File ios/web/web_state/web_state_impl.mm (right):

https://codereview.chromium.org/2720983002/diff/1/ios/web/web_state/web_state...
ios/web/web_state/web_state_impl.mm:51:
web_state->GetNavigationManagerImpl().InitializeSession(NO);
Could you please either leave opened_by_dom locakl variable or add /*
opened_by_dom */ inlined comment for NO.

[sdefresne, 2017-02-28 17:40:57]

Patchset #2 (id:20001) has been deleted

[sdefresne, 2017-02-28 17:41:07]

Thank you for the review.

https://codereview.chromium.org/2720983002/diff/1/ios/chrome/browser/tabs/tab.h
File ios/chrome/browser/tabs/tab.h (right):

https://codereview.chromium.org/2720983002/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab.h:187: // -initWithBrowserState:opener:model.
On 2017/02/28 16:04:09, Eugene But wrote:
> initWithBrowserState:opener:openedByDOM:model: ?

Done.

https://codereview.chromium.org/2720983002/diff/1/ios/chrome/browser/tabs/tab...
File ios/chrome/browser/tabs/tab_model_unittest.mm (right):

https://codereview.chromium.org/2720983002/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab_model_unittest.mm:190: [window
On 2017/02/28 16:04:09, Eugene But wrote:
> Optional nit: Do you want to create local session_storage variable to improve
> the formatting?

Done.

https://codereview.chromium.org/2720983002/diff/1/ios/web/web_state/web_state...
File ios/web/web_state/web_state_impl.mm (right):

https://codereview.chromium.org/2720983002/diff/1/ios/web/web_state/web_state...
ios/web/web_state/web_state_impl.mm:51:
web_state->GetNavigationManagerImpl().InitializeSession(NO);
On 2017/02/28 16:04:09, Eugene But wrote:
> Could you please either leave opened_by_dom locakl variable or add /*
> opened_by_dom */ inlined comment for NO.

Done.

[rohitrao (ping after 24h), 2017-02-28 22:39:15]

Tab LGTM

[sdefresne, 2017-03-01 00:28:52]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-03-01 00:28:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2720983002/#ps40001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-03-01 00:30:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 01:14:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488328132882510,
"parent_rev": "e1305c0956ce941b268092bb3cbd05840c70eef1", "commit_rev":
"a6395911b0dc6cad281c0e13c62578689be02b93"}

[commit-bot: I haz the power, 2017-03-01 01:16:04]

Description was changed from

==========
Remove windowName from CRWSessionController.

The windowName parameter passed during the Tab creation was always
nil (either directly passed as nil or forwarded from the caller)
except during unit tests.

Remove the property from CRWSessionController and convert the unit
tests to no longer set this parameter (instead comparing the object
directly) and remove the parameter from all methods taking windowName.

Re-order some parameter in initialiser to put more important
parameter first (e.g. -initWithBrowserState:openedByDOM versus
-initWithOpenedByDOM:browserState:).

BUG=620465
==========

to

==========
Remove windowName from CRWSessionController.

The windowName parameter passed during the Tab creation was always
nil (either directly passed as nil or forwarded from the caller)
except during unit tests.

Remove the property from CRWSessionController and convert the unit
tests to no longer set this parameter (instead comparing the object
directly) and remove the parameter from all methods taking windowName.

Re-order some parameter in initialiser to put more important
parameter first (e.g. -initWithBrowserState:openedByDOM versus
-initWithOpenedByDOM:browserState:).

BUG=620465

Review-Url: https://codereview.chromium.org/2720983002
Cr-Commit-Position: refs/heads/master@{#453786}
Committed:
https://chromium.googlesource.com/chromium/src/+/a6395911b0dc6cad281c0e13c625...
==========

[commit-bot: I haz the power, 2017-03-01 01:16:05]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a6395911b0dc6cad281c0e13c625...