Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: ios/web/navigation/crw_session_controller.h

Issue 2720983002: Remove windowName from CRWSessionController. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/ui/url_loader.h ('k') | ios/web/navigation/crw_session_controller.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_WEB_NAVIGATION_CRW_SESSION_CONTROLLER_H_ 5 #ifndef IOS_WEB_NAVIGATION_CRW_SESSION_CONTROLLER_H_
6 #define IOS_WEB_NAVIGATION_CRW_SESSION_CONTROLLER_H_ 6 #define IOS_WEB_NAVIGATION_CRW_SESSION_CONTROLLER_H_
7 7
8 #import <Foundation/Foundation.h> 8 #import <Foundation/Foundation.h>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 18 matching lines...) Expand all
29 // DEPRECATED, do not use this class and do not add any methods to it. 29 // DEPRECATED, do not use this class and do not add any methods to it.
30 // Use web::NavigationManager instead. 30 // Use web::NavigationManager instead.
31 // TODO(crbug.com/454984): Remove this class. 31 // TODO(crbug.com/454984): Remove this class.
32 @interface CRWSessionController : NSObject<NSCopying> 32 @interface CRWSessionController : NSObject<NSCopying>
33 33
34 @property(nonatomic, readonly, assign) NSInteger currentNavigationIndex; 34 @property(nonatomic, readonly, assign) NSInteger currentNavigationIndex;
35 @property(nonatomic, readonly, assign) NSInteger previousNavigationIndex; 35 @property(nonatomic, readonly, assign) NSInteger previousNavigationIndex;
36 // The index of the pending item if it is in |items|, or -1 if |pendingItem| 36 // The index of the pending item if it is in |items|, or -1 if |pendingItem|
37 // corresponds with a new navigation (created by addPendingItem:). 37 // corresponds with a new navigation (created by addPendingItem:).
38 @property(nonatomic, readwrite, assign) NSInteger pendingItemIndex; 38 @property(nonatomic, readwrite, assign) NSInteger pendingItemIndex;
39 @property(nonatomic, copy) NSString* windowName;
40 // Indicates whether the page was opened by DOM (e.g. with |window.open| 39 // Indicates whether the page was opened by DOM (e.g. with |window.open|
41 // JavaScript call or by clicking a link with |_blank| target). 40 // JavaScript call or by clicking a link with |_blank| target).
42 @property(nonatomic, readonly, getter=isOpenedByDOM) BOOL openedByDOM; 41 @property(nonatomic, readonly, getter=isOpenedByDOM) BOOL openedByDOM;
43 @property(nonatomic, readonly, strong) 42 @property(nonatomic, readonly, strong)
44 CRWSessionCertificatePolicyManager* sessionCertificatePolicyManager; 43 CRWSessionCertificatePolicyManager* sessionCertificatePolicyManager;
45 @property(nonatomic, assign) NSTimeInterval lastVisitedTimestamp; 44 @property(nonatomic, assign) NSTimeInterval lastVisitedTimestamp;
46 45
47 // The list of CRWSessionEntries in |_entries|'s NavigationItemImpls. 46 // The list of CRWSessionEntries in |_entries|'s NavigationItemImpls.
48 @property(nonatomic, readonly) web::NavigationItemList items; 47 @property(nonatomic, readonly) web::NavigationItemList items;
49 // The current NavigationItem. During a pending navigation, returns the 48 // The current NavigationItem. During a pending navigation, returns the
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 // same-document navigation. Entries can be passed in any order. 149 // same-document navigation. Entries can be passed in any order.
151 - (BOOL)isSameDocumentNavigationBetweenItem:(web::NavigationItem*)firstItem 150 - (BOOL)isSameDocumentNavigationBetweenItem:(web::NavigationItem*)firstItem
152 andItem:(web::NavigationItem*)secondItem; 151 andItem:(web::NavigationItem*)secondItem;
153 152
154 // Returns the index of |item| in |items|. 153 // Returns the index of |item| in |items|.
155 - (NSInteger)indexOfItem:(const web::NavigationItem*)item; 154 - (NSInteger)indexOfItem:(const web::NavigationItem*)item;
156 155
157 @end 156 @end
158 157
159 #endif // IOS_WEB_NAVIGATION_CRW_SESSION_CONTROLLER_H_ 158 #endif // IOS_WEB_NAVIGATION_CRW_SESSION_CONTROLLER_H_
OLDNEW
« no previous file with comments | « ios/chrome/browser/ui/url_loader.h ('k') | ios/web/navigation/crw_session_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698