Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2188)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/chrome/browser/ui/stack_view/stack_view_controller.mm

Issue 2720983002: Remove windowName from CRWSessionController. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm ('k') | ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/stack_view/stack_view_controller.mm
diff --git a/ios/chrome/browser/ui/stack_view/stack_view_controller.mm b/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
index 7df24be66e689a71d4fb34e279a8def03f05a52d..4caddb22be2d176a23e00b6e757b6e95cd13e520 100644
--- a/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
+++ b/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
@@ -2045,14 +2045,13 @@ NSString* const kDummyToolbarBackgroundViewAnimationKey =
position = [_activeCardSet.tabModel count];
DCHECK(position <= [_activeCardSet.tabModel count]);
- Tab* tab = [_activeCardSet.tabModel insertOrUpdateTabWithURL:URL
- referrer:web::Referrer()
- transition:transition
- windowName:nil
- opener:nil
- openedByDOM:NO
- atIndex:position
- inBackground:NO];
+ Tab* tab = [_activeCardSet.tabModel insertTabWithURL:URL
+ referrer:web::Referrer()
+ transition:transition
+ opener:nil
+ openedByDOM:NO
+ atIndex:position
+ inBackground:NO];
[_activeCardSet.tabModel setCurrentTab:tab];
[_delegate tabSwitcher:self
« no previous file with comments | « ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm ('k') | ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698