Change return type of Tab -navigationManager.

Change return type of Tab -navigationManager.

Change Tab -navigationManager to return a web::NavigationManager
and add a second method to get it as a web::NavigationManagerImpl
called -navigationManagerImpl.

Fixes calling code.

BUG=620465
Review-Url: https://codereview.chromium.org/2718273003
Cr-Commit-Position: refs/heads/master@{#453793}
Committed: https://chromium.googlesource.com/chromium/src/+/dd01aeec177167dc5bb0ff1fb60e5e53a07c0628

[sdefresne, 2017-02-28 19:46:19]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 19:46:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-02-28 19:48:03]

sdefresne@chromium.org changed reviewers:
+ eugenebut@chromium.org, rohitrao@chromium.org

[sdefresne, 2017-02-28 19:48:03]

Please both take a look.

[commit-bot: I haz the power, 2017-02-28 20:31:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 20:31:10]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Eugene But (OOO till 7-30), 2017-02-28 21:39:47]

lgtm

https://codereview.chromium.org/2718273003/diff/1/ios/chrome/browser/tabs/tab.mm
File ios/chrome/browser/tabs/tab.mm (right):

https://codereview.chromium.org/2718273003/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab.mm:877: return webStateImpl_ ?
webStateImpl_->GetNavigationManager() : nullptr;
You can use self.webState here, which returns public web::WebState object

[sdefresne, 2017-03-01 01:33:14]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-03-01 01:33:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2718273003/#ps20001
(title: "Fix BrowserViewControllerTest unit tests.")

[commit-bot: I haz the power, 2017-03-01 01:33:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 02:43:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488331994917500,
"parent_rev": "f1cdf374afee0df705c899ae71ec3970915f9512", "commit_rev":
"dd01aeec177167dc5bb0ff1fb60e5e53a07c0628"}

[commit-bot: I haz the power, 2017-03-01 02:43:51]

Description was changed from

==========
Change return type of Tab -navigationManager.

Change Tab -navigationManager to return a web::NavigationManager
and add a second method to get it as a web::NavigationManagerImpl
called -navigationManagerImpl.

Fixes calling code.

BUG=620465
==========

to

==========
Change return type of Tab -navigationManager.

Change Tab -navigationManager to return a web::NavigationManager
and add a second method to get it as a web::NavigationManagerImpl
called -navigationManagerImpl.

Fixes calling code.

BUG=620465

Review-Url: https://codereview.chromium.org/2718273003
Cr-Commit-Position: refs/heads/master@{#453793}
Committed:
https://chromium.googlesource.com/chromium/src/+/dd01aeec177167dc5bb0ff1fb60e...
==========

[commit-bot: I haz the power, 2017-03-01 02:43:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dd01aeec177167dc5bb0ff1fb60e...