ios/web/web_state/web_state_impl.mm - Issue 2720983002: Remove windowName from CRWSessionController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/web_state_impl.mm

Issue 2720983002: Remove windowName from CRWSessionController. (Closed)

Patch Set: Address comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/web_state_impl.mm

diff --git a/ios/web/web_state/web_state_impl.mm b/ios/web/web_state/web_state_impl.mm

index 960892c0b10ace1bcf806756c106bb0dddaf69a7..72a7aa0c7c668227c88d1b881343e93b170ac0a9 100644

--- a/ios/web/web_state/web_state_impl.mm

+++ b/ios/web/web_state/web_state_impl.mm

@@ -47,11 +47,9 @@ std::unique_ptr<WebState> WebState::Create(const CreateParams& params) {

std::unique_ptr<WebStateImpl> web_state(

new WebStateImpl(params.browser_state));

- // Initialized the new session.

- NSString* window_name = nil;

+ // Initialize the new session.

BOOL opened_by_dom = NO;

- web_state->GetNavigationManagerImpl().InitializeSession(window_name,

- opened_by_dom);

+ web_state->GetNavigationManagerImpl().InitializeSession(opened_by_dom);

// This std::move is required to compile with the version of clang shipping

// with Xcode 8.0+. Evalute whether the issue is fixed once a new version of