Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: ios/web/navigation/crw_session_storage_unittest.mm

Issue 2720983002: Remove windowName from CRWSessionController. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/navigation/crw_session_controller_unittest.mm ('k') | ios/web/navigation/navigation_manager_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/crw_session_storage_unittest.mm
diff --git a/ios/web/navigation/crw_session_storage_unittest.mm b/ios/web/navigation/crw_session_storage_unittest.mm
index 7626ff4c66897630f731afa43f6fd961ad82d16d..4bbd394d70f46aacaa5a01346eab28fb56e843ea 100644
--- a/ios/web/navigation/crw_session_storage_unittest.mm
+++ b/ios/web/navigation/crw_session_storage_unittest.mm
@@ -49,7 +49,6 @@ BOOL SessionStoragesAreEqual(CRWSessionStorage* session1,
NSArray* items2 = session2.itemStorages;
return ItemStorageListsAreEqual(items1, items2) &&
session1.openedByDOM == session2.openedByDOM &&
- [session1.windowName isEqual:session2.windowName] &&
session1.currentNavigationIndex == session2.currentNavigationIndex &&
session1.previousNavigationIndex == session2.previousNavigationIndex &&
session1.lastVisitedTimestamp == session2.lastVisitedTimestamp &&
@@ -63,7 +62,6 @@ class CRWNSessionStorageTest : public PlatformTest {
: session_storage_([[CRWSessionStorage alloc] init]) {
// Set up |session_storage_|.
[session_storage_ setOpenedByDOM:YES];
- [session_storage_ setWindowName:@"windowName"];
[session_storage_ setCurrentNavigationIndex:4];
[session_storage_ setPreviousNavigationIndex:3];
[session_storage_ setLastVisitedTimestamp:CFAbsoluteTimeGetCurrent()];
« no previous file with comments | « ios/web/navigation/crw_session_controller_unittest.mm ('k') | ios/web/navigation/navigation_manager_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698