ios/web/web_state/ui/crw_web_controller_unittest.mm - Issue 2720983002: Remove windowName from CRWSessionController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller_unittest.mm

Issue 2720983002: Remove windowName from CRWSessionController. (Closed)

Patch Set: Address comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller_unittest.mm

diff --git a/ios/web/web_state/ui/crw_web_controller_unittest.mm b/ios/web/web_state/ui/crw_web_controller_unittest.mm

index 9bc1c82bc363f37f4c316fe43272bd33098a2f09..44084e6cf8540427194dfedbd347f7d42d28fa51 100644

--- a/ios/web/web_state/ui/crw_web_controller_unittest.mm

+++ b/ios/web/web_state/ui/crw_web_controller_unittest.mm

@@ -193,7 +193,7 @@ class CRWWebControllerTest : public web::WebTestWithWebController {

NavigationManagerImpl& navigationManager =

[web_controller() webStateImpl]->GetNavigationManagerImpl();

- navigationManager.InitializeSession(@"name", NO);

+ navigationManager.InitializeSession(NO);

navigationManager.AddPendingItem(

GURL("http://www.google.com/?q=foo#bar"), web::Referrer(),

ui::PAGE_TRANSITION_TYPED,

@@ -806,7 +806,7 @@ class CRWWebControllerNativeContentTest : public web::WebTestWithWebController {

void Load(const GURL& URL) {

NavigationManagerImpl& navigation_manager =

[web_controller() webStateImpl]->GetNavigationManagerImpl();

- navigation_manager.InitializeSession(@"name", NO);

+ navigation_manager.InitializeSession(NO);

navigation_manager.AddPendingItem(

URL, web::Referrer(), ui::PAGE_TRANSITION_TYPED,

web::NavigationInitiationType::USER_INITIATED);

« no previous file with comments | « ios/web/public/test/web_test_with_web_state.mm ('k') | ios/web/web_state/web_state_impl.mm » ('j') | no next file with comments »