Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2720613005: Refactor serialisation of openerId & openerNavigationIndex. (Closed)

Created:
3 years, 9 months ago by sdefresne
Modified:
3 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, pkl (ping after 24h if needed), Eugene But (OOO till 7-30), yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, noyau+watch_chromium.org, marq+watch_chromium.org, darin (slow to review), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor serialisation of openerId & openerNavigationIndex. The two properties openerId and openerNavigationIndex of the class CRWSessionController were never used in ios/web/ (as they are used to serialize ios/chrome/ notion of opener of a Tab) so refactor them to use serializable user data. BUG=687207 Review-Url: https://codereview.chromium.org/2720613005 Cr-Commit-Position: refs/heads/master@{#453715} Committed: https://chromium.googlesource.com/chromium/src/+/a504b117059bfa27ecbf7e061c380e1f91c54018

Patch Set 1 #

Patch Set 2 : Fix compilation of crw_session_storage_unittest.mm. #

Patch Set 3 : Fix ios_chrome_unittests. #

Patch Set 4 : Fix CRWSessionController's initializer comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -122 lines) Patch
M ios/chrome/browser/native_app_launcher/native_app_navigation_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sessions/session_window_unittest.mm View 3 chunks +2 lines, -8 lines 0 comments Download
M ios/chrome/browser/tabs/tab.h View 1 chunk +7 lines, -1 line 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 3 chunks +39 lines, -7 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model.mm View 1 chunk +2 lines, -4 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model_unittest.mm View 1 2 3 chunks +12 lines, -4 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/navigation/crw_session_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 1 2 3 5 chunks +7 lines, -23 lines 0 comments Download
M ios/web/navigation/crw_session_controller+private_constructors.h View 1 2 3 1 chunk +7 lines, -10 lines 0 comments Download
M ios/web/navigation/crw_session_controller_unittest.mm View 7 chunks +0 lines, -12 lines 0 comments Download
M ios/web/navigation/crw_session_storage_unittest.mm View 1 2 chunks +0 lines, -4 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.h View 1 chunk +2 lines, -8 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.mm View 1 chunk +1 line, -5 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl_unittest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/navigation/serializable_user_data_manager_impl.mm View 1 chunk +5 lines, -2 lines 0 comments Download
M ios/web/navigation/session_storage_builder.mm View 3 chunks +0 lines, -7 lines 0 comments Download
M ios/web/public/crw_session_storage.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/public/crw_session_storage.mm View 4 chunks +0 lines, -9 lines 0 comments Download
M ios/web/public/test/web_test_with_web_state.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 chunk +2 lines, -4 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/web_ui_mojo_inttest.mm View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (20 generated)
sdefresne
kkhorimoto: Please take a look. eugenebut: FYI
3 years, 9 months ago (2017-02-27 23:57:16 UTC) #4
sdefresne
kkhorimoto: ping
3 years, 9 months ago (2017-02-28 19:38:10 UTC) #15
kkhorimoto
lgtm!
3 years, 9 months ago (2017-02-28 20:28:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720613005/60001
3 years, 9 months ago (2017-02-28 21:50:55 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 21:59:51 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a504b117059bfa27ecbf7e061c38...

Powered by Google App Engine
This is Rietveld 408576698