Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm

Issue 2720983002: Remove windowName from CRWSessionController. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/stack_view/stack_view_controller.mm ('k') | ios/chrome/browser/ui/url_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm
diff --git a/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm b/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm
index 6fb47212d832b8ef2bf2c3d8be957786a0c7ed75..4907234cc4a1dae6497eec6f9cd5ed0b146e83f4 100644
--- a/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm
+++ b/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm
@@ -835,11 +835,10 @@ enum class SnapshotViewOption {
DCHECK(tabModel.browserState);
base::scoped_nsobject<Tab> tab([[Tab alloc]
- initWithWindowName:nil
- opener:nil
- openedByDOM:NO
- model:tabModel
- browserState:tabModel.browserState]);
+ initWithBrowserState:tabModel.browserState
+ opener:nil
+ openedByDOM:NO
+ model:tabModel]);
[tab webController].webUsageEnabled = tabModel.webUsageEnabled;
ProceduralBlock dismissWithNewTab = ^{
@@ -899,14 +898,13 @@ enum class SnapshotViewOption {
// Disable user interactions until the tab is inserted to prevent multiple
// concurrent tab model updates.
[_tabSwitcherView setUserInteractionEnabled:NO];
- Tab* tab = [mainModel insertOrUpdateTabWithURL:GURL()
- referrer:web::Referrer()
- transition:ui::PAGE_TRANSITION_TYPED
- windowName:nil
- opener:nil
- openedByDOM:NO
- atIndex:NSNotFound
- inBackground:NO];
+ Tab* tab = [mainModel insertTabWithURL:GURL()
+ referrer:web::Referrer()
+ transition:ui::PAGE_TRANSITION_TYPED
+ opener:nil
+ openedByDOM:NO
+ atIndex:NSNotFound
+ inBackground:NO];
[tab loadSessionTab:toLoad];
[mainModel setCurrentTab:tab];
« no previous file with comments | « ios/chrome/browser/ui/stack_view/stack_view_controller.mm ('k') | ios/chrome/browser/ui/url_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698