Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

Issue 2720983002: Remove windowName from CRWSessionController. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/content_suggestions/content_suggestions_coordinator. h" 5 #import "ios/chrome/browser/content_suggestions/content_suggestions_coordinator. h"
6 6
7 #include "base/mac/scoped_nsobject.h" 7 #include "base/mac/scoped_nsobject.h"
8 #include "base/strings/sys_string_conversions.h" 8 #include "base/strings/sys_string_conversions.h"
9 #import "ios/chrome/browser/content_suggestions/content_suggestions_mediator.h" 9 #import "ios/chrome/browser/content_suggestions/content_suggestions_mediator.h"
10 #include "ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service _factory.h" 10 #include "ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service _factory.h"
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 [self.alertCoordinator start]; 159 [self.alertCoordinator start];
160 } 160 }
161 161
162 #pragma mark - Private 162 #pragma mark - Private
163 163
164 - (void)openNewTabWithURL:(const GURL&)URL incognito:(BOOL)incognito { 164 - (void)openNewTabWithURL:(const GURL&)URL incognito:(BOOL)incognito {
165 // TODO(crbug.com/691979): Add metrics. 165 // TODO(crbug.com/691979): Add metrics.
166 166
167 [self.URLLoader webPageOrderedOpen:URL 167 [self.URLLoader webPageOrderedOpen:URL
168 referrer:web::Referrer() 168 referrer:web::Referrer()
169 windowName:nil
170 inIncognito:incognito 169 inIncognito:incognito
171 inBackground:NO 170 inBackground:NO
172 appendTo:kLastTab]; 171 appendTo:kLastTab];
173 172
174 [self stop]; 173 [self stop];
175 } 174 }
176 175
177 - (void)removeEntry { 176 - (void)removeEntry {
178 // TODO(crbug.com/691979): Add metrics. 177 // TODO(crbug.com/691979): Add metrics.
179 } 178 }
180 179
181 @end 180 @end
OLDNEW
« no previous file with comments | « ios/chrome/app/main_controller.mm ('k') | ios/chrome/browser/native_app_launcher/native_app_navigation_util_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698