Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/ (Closed)

Created:
7 years, 3 months ago by Devlin
Modified:
7 years, 3 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, dcheng, rginda+watch_chromium.org, davemoore+watch_chromium.org, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, vsevik, aboxhall+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, jennb, jianli, paulirish+reviews_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, ctguil+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, Dmitry Titov, yurys, davidbarr+watch_chromium.org, jshin+watch_chromium.org, dtseng+watch_chromium.org, pfeldman, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move the rest of extension_manifest_constants to top-level extensions/ Move the rest of chrome/common/extensions/extension_manifest_constants to extensions/common/manifest_constants. s/extension_manifest_[values|errors]/extensions::manifest_[values|errors] Remove include of manifest constants in ~20 files that didn't use it. Fixed small nits when I found (taking out unnecessary extensions::, etc). TBR=davemoore@chromium.org (c/b/chromeos/) TBR=pkotwicz@chromium.org (c/b/themes/) TBR=thakis@chromium.org (c/b/ui/cocoa/, c/renderer/) TBR=dimich@chromium.org (c/b/ui/panels/) TBR=sky@chromium.org (c/b/ui/views/) TBR=finnur@chromium.org (c/b/ui/webui/extensions/) BUG=159265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223318

Patch Set 1 : #

Patch Set 2 : Latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1234 lines, -1279 lines) Patch
M chrome/browser/chromeos/file_manager/zip_file_creator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/commands/command_service_browsertest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/identity/experimental_identity_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/spellcheck/spellcheck_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/browser_permissions_policy_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/bundle_installer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_protocols_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 4 chunks +19 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/extensions/requirements_checker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/browser_action_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/command_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/commands/commands_handler.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/common/extensions/api/commands/commands_manifest_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/extension_action/browser_action_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/extension_action/page_action_handler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/extension_action/script_badge_handler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/file_handlers/file_handlers_parser.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/i18n/default_locale_handler.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/identity/extension_manifests_auth_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/identity/oauth2_manifest_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/input_ime/input_components_handler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/managed_mode_private/managed_mode_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/media_galleries_private/media_galleries_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/omnibox/omnibox_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/plugins/plugins_handler.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/spellcheck/spellcheck_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/system_indicator/system_indicator_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/url_handlers/url_handlers_parser.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/background_info.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/common/extensions/command.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/common/extensions/csp_handler.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/common/extensions/extension_manifest_constants.h View 1 chunk +0 lines, -279 lines 0 comments Download
D chrome/common/extensions/extension_manifest_constants.cc View 1 chunk +0 lines, -497 lines 0 comments Download
M chrome/common/extensions/incognito_handler.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_handler_helpers.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/app_isolation_info.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/app_launch_info.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/icons_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/kiosk_enabled_info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/offline_enabled_info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/requirements_handler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/sandboxed_page_info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/shared_module_info.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/theme_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifest_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_contentsecuritypolicy_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_default_extent_path_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_experimental_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_isolatedapp_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_kiosk_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_ui_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_web_accessible_resources_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_url_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/message_bundle.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/message_bundle_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/mime_types_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission_set.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/common/extensions/permissions/permissions_data.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/permissions/permissions_data_unittest.cc View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/sync_type_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/web_accessible_resources_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/renderer_permissions_policy_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/user_script_scheduler.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/extensions/unpacker.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/utility/extensions/unpacker_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M extensions/common/manifest_constants.h View 1 chunk +414 lines, -146 lines 0 comments Download
M extensions/common/manifest_constants.cc View 1 chunk +491 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Devlin
Sorry for the size. Zero functional changes.
7 years, 3 months ago (2013-09-11 00:49:11 UTC) #1
Yoyo Zhou
LGTM
7 years, 3 months ago (2013-09-13 02:39:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/23744004/4001
7 years, 3 months ago (2013-09-13 18:22:15 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=78794
7 years, 3 months ago (2013-09-14 00:34:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/23744004/4001
7 years, 3 months ago (2013-09-16 03:10:50 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 08:53:45 UTC) #6
Message was sent while issue was closed. 
Change committed as 223318

Powered by Google App Engine
This is Rietveld 408576698