Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc

Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_manifest_constants.h"
6 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
7 #include "chrome/common/extensions/manifest_url_handler.h" 6 #include "chrome/common/extensions/manifest_url_handler.h"
7 #include "extensions/common/manifest_constants.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace errors = extension_manifest_errors; 10 namespace errors = extensions::manifest_errors;
11 11
12 class OptionsPageManifestTest : public ExtensionManifestTest { 12 class OptionsPageManifestTest : public ExtensionManifestTest {
13 }; 13 };
14 14
15 TEST_F(OptionsPageManifestTest, OptionsPageInApps) { 15 TEST_F(OptionsPageManifestTest, OptionsPageInApps) {
16 scoped_refptr<extensions::Extension> extension; 16 scoped_refptr<extensions::Extension> extension;
17 17
18 // Allow options page with absolute URL in hosted apps. 18 // Allow options page with absolute URL in hosted apps.
19 extension = LoadAndExpectSuccess("hosted_app_absolute_options.json"); 19 extension = LoadAndExpectSuccess("hosted_app_absolute_options.json");
20 EXPECT_STREQ("http", 20 EXPECT_STREQ("http",
(...skipping 19 matching lines...) Expand all
40 Testcase("hosted_app_file_options.json", 40 Testcase("hosted_app_file_options.json",
41 errors::kInvalidOptionsPageInHostedApp), 41 errors::kInvalidOptionsPageInHostedApp),
42 42
43 // Forbid absolute URL for options page in packaged apps. 43 // Forbid absolute URL for options page in packaged apps.
44 Testcase("packaged_app_absolute_options.json", 44 Testcase("packaged_app_absolute_options.json",
45 errors::kInvalidOptionsPageExpectUrlInPackage) 45 errors::kInvalidOptionsPageExpectUrlInPackage)
46 }; 46 };
47 RunTestcases(testcases, arraysize(testcases), 47 RunTestcases(testcases, arraysize(testcases),
48 EXPECT_TYPE_ERROR); 48 EXPECT_TYPE_ERROR);
49 } 49 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698