Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: chrome/utility/extensions/unpacker_unittest.cc

Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/utility/extensions/unpacker.cc ('k') | extensions/common/manifest_constants.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_util.h" 5 #include "base/file_util.h"
6 #include "base/files/scoped_temp_dir.h" 6 #include "base/files/scoped_temp_dir.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/values.h" 10 #include "base/values.h"
11 #include "chrome/common/chrome_paths.h" 11 #include "chrome/common/chrome_paths.h"
12 #include "chrome/common/extensions/extension.h" 12 #include "chrome/common/extensions/extension.h"
13 #include "chrome/common/extensions/extension_manifest_constants.h"
14 #include "chrome/utility/extensions/unpacker.h" 13 #include "chrome/utility/extensions/unpacker.h"
15 #include "extensions/common/constants.h" 14 #include "extensions/common/constants.h"
15 #include "extensions/common/manifest_constants.h"
16 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
17 #include "third_party/skia/include/core/SkBitmap.h" 17 #include "third_party/skia/include/core/SkBitmap.h"
18 18
19 namespace errors = extension_manifest_errors;
20 namespace keys = extensions::manifest_keys;
21
22 namespace extensions { 19 namespace extensions {
23 20
21 namespace errors = manifest_errors;
22 namespace keys = manifest_keys;
23
24 class UnpackerTest : public testing::Test { 24 class UnpackerTest : public testing::Test {
25 public: 25 public:
26 virtual ~UnpackerTest() { 26 virtual ~UnpackerTest() {
27 LOG(WARNING) << "Deleting temp dir: " 27 LOG(WARNING) << "Deleting temp dir: "
28 << temp_dir_.path().LossyDisplayName(); 28 << temp_dir_.path().LossyDisplayName();
29 LOG(WARNING) << temp_dir_.Delete(); 29 LOG(WARNING) << temp_dir_.Delete();
30 } 30 }
31 31
32 void SetupUnpacker(const std::string& crx_name) { 32 void SetupUnpacker(const std::string& crx_name) {
33 base::FilePath original_path; 33 base::FilePath original_path;
34 ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &original_path)); 34 ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &original_path));
35 original_path = original_path.AppendASCII("extensions") 35 original_path = original_path.AppendASCII("extensions")
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 SetupUnpacker("bad_image.crx"); 167 SetupUnpacker("bad_image.crx");
168 EXPECT_FALSE(unpacker_->Run()); 168 EXPECT_FALSE(unpacker_->Run());
169 EXPECT_TRUE(StartsWith(unpacker_->error_message(), 169 EXPECT_TRUE(StartsWith(unpacker_->error_message(),
170 ASCIIToUTF16(kExpected), 170 ASCIIToUTF16(kExpected),
171 false)) << "Expected prefix: \"" << kExpected 171 false)) << "Expected prefix: \"" << kExpected
172 << "\", actual error: \"" << unpacker_->error_message() 172 << "\", actual error: \"" << unpacker_->error_message()
173 << "\""; 173 << "\"";
174 } 174 }
175 175
176 } // namespace extensions 176 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/utility/extensions/unpacker.cc ('k') | extensions/common/manifest_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698