Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc

Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/common/extensions/extension_manifest_constants.h"
10 #include "extensions/common/error_utils.h" 9 #include "extensions/common/error_utils.h"
10 #include "extensions/common/manifest_constants.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 12
13 using extensions::ErrorUtils; 13 using extensions::ErrorUtils;
14 using extensions::Extension; 14 using extensions::Extension;
15 15
16 namespace errors = extension_manifest_errors; 16 namespace errors = extensions::manifest_errors;
17 17
18 TEST_F(ExtensionManifestTest, AppWebUrls) { 18 TEST_F(ExtensionManifestTest, AppWebUrls) {
19 Testcase testcases[] = { 19 Testcase testcases[] = {
20 Testcase("web_urls_wrong_type.json", errors::kInvalidWebURLs), 20 Testcase("web_urls_wrong_type.json", errors::kInvalidWebURLs),
21 Testcase("web_urls_invalid_1.json", 21 Testcase("web_urls_invalid_1.json",
22 ErrorUtils::FormatErrorMessage( 22 ErrorUtils::FormatErrorMessage(
23 errors::kInvalidWebURL, 23 errors::kInvalidWebURL,
24 base::IntToString(0), 24 base::IntToString(0),
25 errors::kExpectString)), 25 errors::kExpectString)),
26 Testcase("web_urls_invalid_2.json", 26 Testcase("web_urls_invalid_2.json",
(...skipping 22 matching lines...) Expand all
49 EXPECT_TYPE_ERROR); 49 EXPECT_TYPE_ERROR);
50 50
51 LoadAndExpectSuccess("web_urls_has_port.json"); 51 LoadAndExpectSuccess("web_urls_has_port.json");
52 52
53 scoped_refptr<Extension> extension( 53 scoped_refptr<Extension> extension(
54 LoadAndExpectSuccess("web_urls_default.json")); 54 LoadAndExpectSuccess("web_urls_default.json"));
55 ASSERT_EQ(1u, extension->web_extent().patterns().size()); 55 ASSERT_EQ(1u, extension->web_extent().patterns().size());
56 EXPECT_EQ("*://www.google.com/*", 56 EXPECT_EQ("*://www.google.com/*",
57 extension->web_extent().patterns().begin()->GetAsString()); 57 extension->web_extent().patterns().begin()->GetAsString());
58 } 58 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698