chrome/common/extensions/manifest_handlers/app_launch_info.cc - Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/app_launch_info.cc

Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/app_isolation_info.cc ('k') | chrome/common/extensions/manifest_handlers/content_scripts_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/app_launch_info.cc

diff --git a/chrome/common/extensions/manifest_handlers/app_launch_info.cc b/chrome/common/extensions/manifest_handlers/app_launch_info.cc

index 4b9ee12d71282a8f76a41ddbb76ec36718e69e68..dc22f1c900719cb5e5a3e91bde8d768d5602e34c 100644

--- a/chrome/common/extensions/manifest_handlers/app_launch_info.cc

+++ b/chrome/common/extensions/manifest_handlers/app_launch_info.cc

@@ -10,16 +10,16 @@

#include "base/strings/utf_string_conversions.h"

#include "base/values.h"

#include "chrome/common/chrome_switches.h"

-#include "chrome/common/extensions/extension_manifest_constants.h"

#include "chrome/common/url_constants.h"

#include "extensions/common/error_utils.h"

-namespace keys = extensions::manifest_keys;

-namespace values = extension_manifest_values;

-namespace errors = extension_manifest_errors;

+#include "extensions/common/manifest_constants.h"

namespace extensions {

+namespace keys = manifest_keys;

+namespace values = manifest_values;

+namespace errors = manifest_errors;

namespace {

bool ReadLaunchDimension(const extensions::Manifest* manifest,