chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc - Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc

Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/identity/identity_api.cc ('k') | chrome/browser/extensions/api/spellcheck/spellcheck_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc

diff --git a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc

index f59c76050c88b5644b148bbd9dd0ef851299e236..838fc6a82deb14eef01d277563d569546737d9f9 100644

--- a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc

+++ b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc

@@ -18,14 +18,11 @@

#include "chrome/browser/sync/profile_sync_service_factory.h"

#include "chrome/browser/sync/profile_sync_service_mock.h"

#include "chrome/common/extensions/extension.h"

-#include "chrome/common/extensions/extension_manifest_constants.h"

#include "chrome/common/pref_names.h"

#include "chrome/test/base/browser_with_test_window_test.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

-using extensions::Extension;

-using extensions::TestExtensionPrefs;

using browser_sync::DeviceInfo;

using testing::Return;

@@ -128,8 +125,7 @@ class ExtensionSignedInDevicesTest : public BrowserWithTestWindowTest {

ProfileSyncServiceFactory::GetInstance()->SetTestingFactory(

profile(), CreateProfileSyncServiceMock);

- extension_ = utils::CreateEmptyExtensionWithLocation(

- extensions::Manifest::UNPACKED);

+ extension_ = utils::CreateEmptyExtensionWithLocation(Manifest::UNPACKED);

}

@@ -149,7 +145,7 @@ class ExtensionSignedInDevicesTest : public BrowserWithTestWindowTest {

}

protected:

- scoped_refptr<extensions::Extension> extension_;

+ scoped_refptr<Extension> extension_;

};

DeviceInfo* CreateDeviceInfo(const DeviceInfo& device_info) {