chrome/browser/ui/views/browser_action_view.cc - Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/browser_action_view.cc

Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/panels/panel_browsertest.cc ('k') | chrome/browser/ui/views/location_bar/page_action_image_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/browser_action_view.cc

diff --git a/chrome/browser/ui/views/browser_action_view.cc b/chrome/browser/ui/views/browser_action_view.cc

index ed0a2f9dc257ec57aa0593ea348d57cac80f4ea2..db1b228fc7116407ea7bfe22abc83bc4866c57fc 100644

--- a/chrome/browser/ui/views/browser_action_view.cc

+++ b/chrome/browser/ui/views/browser_action_view.cc

@@ -17,7 +17,7 @@

#include "chrome/browser/ui/views/browser_actions_container.h"

#include "chrome/browser/ui/views/toolbar_view.h"

#include "chrome/common/extensions/extension.h"

-#include "chrome/common/extensions/extension_manifest_constants.h"

+#include "extensions/common/manifest_constants.h"

#include "grit/generated_resources.h"

#include "grit/theme_resources.h"

#include "ui/base/accessibility/accessible_view_state.h"

@@ -285,7 +285,7 @@ void BrowserActionButton::Observe(int type,

details).ptr();

if (extension_->id() == payload->first &&

payload->second ==

- extension_manifest_values::kBrowserActionCommandEvent) {

+ extensions::manifest_values::kBrowserActionCommandEvent) {

if (type == chrome::NOTIFICATION_EXTENSION_COMMAND_ADDED)

MaybeRegisterExtensionCommand();

else

« no previous file with comments | « chrome/browser/ui/panels/panel_browsertest.cc ('k') | chrome/browser/ui/views/location_bar/page_action_image_view.cc » ('j') | no next file with comments »