chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc ('k') | chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index 106043690a764151466a999029b07d7ed2675aa1..d0f23482891b179d8b8324de4170ba74cb5798f8 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -58,7 +58,6 @@

#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/extension_file_util.h"

#include "chrome/common/extensions/extension_l10n_util.h"

-#include "chrome/common/extensions/extension_manifest_constants.h"

#include "chrome/common/extensions/extension_messages.h"

#include "chrome/common/extensions/incognito_handler.h"

#include "chrome/common/extensions/message_bundle.h"

@@ -80,6 +79,7 @@

#include "extensions/browser/file_reader.h"

#include "extensions/common/constants.h"

#include "extensions/common/error_utils.h"

+#include "extensions/common/manifest_constants.h"

#include "extensions/common/user_script.h"

#include "skia/ext/image_operations.h"

#include "skia/ext/platform_canvas.h"

@@ -111,7 +111,7 @@ using content::WebContents;

namespace extensions {

namespace windows = api::windows;

-namespace errors = extension_manifest_errors;

+namespace errors = manifest_errors;

namespace keys = tabs_constants;

namespace tabs = api::tabs;

typedef tabs::CaptureVisibleTab::Params::Options FormatEnum;