Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: chrome/common/extensions/manifest_handlers/requirements_handler.cc

Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_handlers/requirements_handler.h" 5 #include "chrome/common/extensions/manifest_handlers/requirements_handler.h"
6 6
7 #include "base/lazy_instance.h" 7 #include "base/lazy_instance.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/values.h" 10 #include "base/values.h"
11 #include "chrome/common/extensions/extension_manifest_constants.h"
12 #include "extensions/common/error_utils.h" 11 #include "extensions/common/error_utils.h"
13 12 #include "extensions/common/manifest_constants.h"
14 namespace keys = extensions::manifest_keys;
15 namespace errors = extension_manifest_errors;
16 13
17 namespace extensions { 14 namespace extensions {
18 15
16 namespace keys = manifest_keys;
17 namespace errors = manifest_errors;
18
19 RequirementsInfo::RequirementsInfo(const Manifest* manifest) 19 RequirementsInfo::RequirementsInfo(const Manifest* manifest)
20 : webgl(false), 20 : webgl(false),
21 css3d(false), 21 css3d(false),
22 npapi(false) { 22 npapi(false) {
23 // Before parsing requirements from the manifest, automatically default the 23 // Before parsing requirements from the manifest, automatically default the
24 // NPAPI plugin requirement based on whether it includes NPAPI plugins. 24 // NPAPI plugin requirement based on whether it includes NPAPI plugins.
25 const base::ListValue* list_value = NULL; 25 const base::ListValue* list_value = NULL;
26 npapi = manifest->GetList(keys::kPlugins, &list_value) && 26 npapi = manifest->GetList(keys::kPlugins, &list_value) &&
27 !list_value->empty(); 27 !list_value->empty();
28 } 28 }
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 *error = ASCIIToUTF16(errors::kInvalidRequirements); 132 *error = ASCIIToUTF16(errors::kInvalidRequirements);
133 return false; 133 return false;
134 } 134 }
135 } 135 }
136 136
137 extension->SetManifestData(keys::kRequirements, requirements.release()); 137 extension->SetManifestData(keys::kRequirements, requirements.release());
138 return true; 138 return true;
139 } 139 }
140 140
141 } // namespace extensions 141 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698