Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/common/extensions/manifest_handlers/app_launch_info.cc

Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h" 5 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
11 #include "base/values.h" 11 #include "base/values.h"
12 #include "chrome/common/chrome_switches.h" 12 #include "chrome/common/chrome_switches.h"
13 #include "chrome/common/extensions/extension_manifest_constants.h"
14 #include "chrome/common/url_constants.h" 13 #include "chrome/common/url_constants.h"
15 #include "extensions/common/error_utils.h" 14 #include "extensions/common/error_utils.h"
16 15 #include "extensions/common/manifest_constants.h"
17 namespace keys = extensions::manifest_keys;
18 namespace values = extension_manifest_values;
19 namespace errors = extension_manifest_errors;
20 16
21 namespace extensions { 17 namespace extensions {
22 18
19 namespace keys = manifest_keys;
20 namespace values = manifest_values;
21 namespace errors = manifest_errors;
22
23 namespace { 23 namespace {
24 24
25 bool ReadLaunchDimension(const extensions::Manifest* manifest, 25 bool ReadLaunchDimension(const extensions::Manifest* manifest,
26 const char* key, 26 const char* key,
27 int* target, 27 int* target,
28 bool is_valid_container, 28 bool is_valid_container,
29 string16* error) { 29 string16* error) {
30 const Value* temp = NULL; 30 const Value* temp = NULL;
31 if (manifest->Get(key, &temp)) { 31 if (manifest->Get(key, &temp)) {
32 if (!is_valid_container) { 32 if (!is_valid_container) {
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 keys::kLaunchLocalPath, 316 keys::kLaunchLocalPath,
317 keys::kLaunchWebURL, 317 keys::kLaunchWebURL,
318 keys::kLaunchContainer, 318 keys::kLaunchContainer,
319 keys::kLaunchHeight, 319 keys::kLaunchHeight,
320 keys::kLaunchWidth 320 keys::kLaunchWidth
321 }; 321 };
322 return std::vector<std::string>(keys, keys + arraysize(keys)); 322 return std::vector<std::string>(keys, keys + arraysize(keys));
323 } 323 }
324 324
325 } // namespace extensions 325 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698