Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 11728003: Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc} (Closed)

Created:
7 years, 11 months ago by darin (slow to review)
Modified:
7 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, jam, yusukes+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dcheng, Albert Bodenhamer, markusheintz_, Ilya Sherman, kinuko+watch, cbentzel+watch_chromium.org, vsevik, Aaron Boodman, benquan, kkania, dbeam+watch-autofill_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, tzik+watch_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, dyu1, penghuang+watch_chromium.org, gavinp+prer_chromium.org, pam+watch_chromium.org, Raman Kakilate, yurys, benjhayden+dwatch_chromium.org, dominich+watch_chromium.org, robertshield, Dane Wallinga, rdsmith+dwatch_chromium.org, ajwong+watch_chromium.org, estade+watch_chromium.org, James Su, mmenke, pfeldman
Visibility:
Public.

Description

Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc} to take std::string (UTF-8) instead of std::wstring. This seems to help simplify callsites considerably. TBR=jam@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174880

Patch Set 1 #

Patch Set 2 : Adding files for interactive_ui_tests #

Patch Set 3 : Adding files for gpu_tests and NaCl browser tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1214 lines, -995 lines) Patch
M chrome/browser/autofill/autofill_browsertest.cc View 18 chunks +100 lines, -85 lines 0 comments Download
M chrome/browser/automation/automation_misc_browsertest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 1 9 chunks +34 lines, -26 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_browsertest.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/chrome_switches_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/do_not_track_browsertest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 6 chunks +14 lines, -10 lines 0 comments Download
M chrome/browser/extensions/chrome_app_api_browsertest.cc View 7 chunks +56 lines, -48 lines 0 comments Download
M chrome/browser/extensions/content_script_apitest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/docs/examples/apps/calculator_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_bindings_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_dom_clipboard_apitest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_icon_source_apitest.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_incognito_apitest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 1 3 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_nacl_browsertest.cc View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_resource_request_policy_apitest.cc View 12 chunks +46 lines, -34 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/browser/extensions/isolated_app_browsertest.cc View 7 chunks +35 lines, -34 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/options_page_apitest.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/extensions/plugin_apitest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/subscribe_page_action_browsertest.cc View 4 chunks +50 lines, -49 lines 0 comments Download
M chrome/browser/extensions/web_contents_browsertest.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/extensions/web_view_browsertest.cc View 11 chunks +94 lines, -63 lines 0 comments Download
M chrome/browser/extensions/webstore_standalone_install_browsertest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 14 chunks +29 lines, -23 lines 0 comments Download
M chrome/browser/history/history_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 1 3 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/loadtimes_extension_bindings_browsertest.cc View 3 chunks +21 lines, -14 lines 0 comments Download
M chrome/browser/net/load_timing_observer_browsertest.cc View 1 chunk +12 lines, -8 lines 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 4 chunks +39 lines, -39 lines 0 comments Download
M chrome/browser/policy/policy_prefs_browsertest.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/popup_blocker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 7 chunks +27 lines, -19 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 13 chunks +47 lines, -29 lines 0 comments Download
M chrome/browser/tab_contents/view_source_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/browser_focus_uitest.cc View 1 6 chunks +16 lines, -12 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui_browsertest.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui_browsertest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.cc View 8 chunks +93 lines, -90 lines 0 comments Download
M chrome/test/base/tracing_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/gpu/gpu_pixel_browsertest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/bookmarklet_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 34 chunks +70 lines, -78 lines 0 comments Download
M content/browser/database_browsertest.cc View 3 chunks +12 lines, -7 lines 0 comments Download
M content/browser/dom_storage/dom_storage_browsertest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/encrypted_media_browsertest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 33 chunks +106 lines, -72 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win_browsertest.cc View 6 chunks +18 lines, -12 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 3 chunks +12 lines, -4 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webrtc_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.h View 2 chunks +8 lines, -8 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 5 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jam
lgtm
7 years, 11 months ago (2013-01-02 16:04:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/11728003/4074
7 years, 11 months ago (2013-01-02 20:46:53 UTC) #2
darin (slow to review)
7 years, 11 months ago (2013-01-02 20:47:27 UTC) #3
darin (slow to review)
7 years, 11 months ago (2013-01-02 20:47:28 UTC) #4
darin (slow to review)
7 years, 11 months ago (2013-01-02 20:47:30 UTC) #5
darin (slow to review)
7 years, 11 months ago (2013-01-02 20:47:32 UTC) #6
darin (slow to review)
7 years, 11 months ago (2013-01-02 20:47:33 UTC) #7
commit-bot: I haz the power
Change committed as 174880
7 years, 11 months ago (2013-01-02 22:44:16 UTC) #8
gavinp
On 2013/01/02 22:44:16, I haz the power (commit-bot) wrote: > Change committed as 174880 Note ...
7 years, 11 months ago (2013-01-03 16:33:12 UTC) #9
jam
On Thu, Jan 3, 2013 at 8:33 AM, <gavinp@chromium.org> wrote: > On 2013/01/02 22:44:16, I ...
7 years, 11 months ago (2013-01-03 16:46:35 UTC) #10
gavinp
7 years, 11 months ago (2013-01-03 16:51:29 UTC) #11
Message was sent while issue was closed.
On 2013/01/03 16:46:35, John Abd-El-Malek wrote:
> On Thu, Jan 3, 2013 at 8:33 AM, <mailto:gavinp@chromium.org> wrote:
> 
> > On 2013/01/02 22:44:16, I haz the power (commit-bot) wrote:
> >
> >> Change committed as 174880
> >>
> >
> > Note this was reverted in
>
https://codereview.chromium.**org/11734018/%3Chttps://codereview.chromium.org...>
> 
> 
> just on a branch...
> 

*phew*. I will now pull from trunk with comfort.

- Gavin

> >
> >
> >
>
https://chromiumcodereview.**appspot.com/11728003/%3Chttps://chromiumcoderevi...>
> >

Powered by Google App Engine
This is Rietveld 408576698