Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3577)

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 11728003: Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding files for gpu_tests and NaCl browser tests. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_focus_uitest.cc ('k') | chrome/browser/ui/panels/panel_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
diff --git a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
index 59ae8f2929b42732d601c6a10332f689c3e4b362..d30228f564ef0970ee83918c1c6a2b313fc49701 100644
--- a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
+++ b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
@@ -471,8 +471,8 @@ bool FocusedOnPage(WebContents* web_contents, std::string* result)
bool FocusedOnPage(WebContents* web_contents, std::string* result) {
return content::ExecuteJavaScriptAndExtractString(
web_contents->GetRenderViewHost(),
- L"",
- L"window.domAutomationController.send(getFocusedElement());",
+ "",
+ "window.domAutomationController.send(getFocusedElement());",
result);
}
@@ -516,8 +516,8 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindInPageEndState) {
// Move the selection to link 1, after searching.
ASSERT_TRUE(content::ExecuteJavaScriptAndExtractString(
web_contents->GetRenderViewHost(),
- L"",
- L"window.domAutomationController.send(selectLink1());",
+ "",
+ "window.domAutomationController.send(selectLink1());",
&result));
// End the find session.
@@ -590,8 +590,8 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
std::string result;
ASSERT_TRUE(content::ExecuteJavaScriptAndExtractString(
web_contents->GetRenderViewHost(),
- L"",
- L"window.domAutomationController.send(selectLink1());",
+ "",
+ "window.domAutomationController.send(selectLink1());",
&result));
// Do a find-next after the selection. This should move forward
@@ -620,8 +620,8 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
std::string result;
ASSERT_TRUE(content::ExecuteJavaScriptAndExtractString(
web_contents->GetRenderViewHost(),
- std::wstring(),
- L"window.domAutomationController.send(selectSpan());",
+ "",
+ "window.domAutomationController.send(selectSpan());",
&result));
// Do a find-next after the selection. This should select the 2nd occurrence
« no previous file with comments | « chrome/browser/ui/browser_focus_uitest.cc ('k') | chrome/browser/ui/panels/panel_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698