Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 11728003: Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding files for gpu_tests and NaCl browser tests. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_sanity_browsertest.cc
diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc
index 6a73eca20533cd6e2cde19fafd1798ae73dd3cf5..0f40d9ec2c5e1e020168e4b15c0adc4b46464efa 100644
--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc
+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc
@@ -100,18 +100,17 @@ void RunTestFunction(DevToolsWindow* window, const char* test_name) {
ASSERT_TRUE(
content::ExecuteJavaScriptAndExtractString(
window->GetRenderViewHost(),
- L"",
- L"window.domAutomationController.send("
- L"'' + (window.uiTests && (typeof uiTests.runTest)));",
+ "",
+ "window.domAutomationController.send("
+ " '' + (window.uiTests && (typeof uiTests.runTest)));",
&result));
if (result == "function") {
ASSERT_TRUE(
content::ExecuteJavaScriptAndExtractString(
window->GetRenderViewHost(),
- L"",
- UTF8ToWide(base::StringPrintf("uiTests.runTest('%s')",
- test_name)),
+ "",
+ base::StringPrintf("uiTests.runTest('%s')", test_name),
&result));
EXPECT_EQ("[OK]", result);
} else {
@@ -533,9 +532,9 @@ IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestPageWithNoJavaScript) {
ASSERT_TRUE(
content::ExecuteJavaScriptAndExtractString(
window_->GetRenderViewHost(),
- L"",
- L"window.domAutomationController.send("
- L"'' + (window.uiTests && (typeof uiTests.runTest)));",
+ "",
+ "window.domAutomationController.send("
+ " '' + (window.uiTests && (typeof uiTests.runTest)));",
&result));
ASSERT_EQ("function", result) << "DevTools front-end is broken.";
CloseDevToolsWindow();
« no previous file with comments | « chrome/browser/content_settings/content_settings_browsertest.cc ('k') | chrome/browser/do_not_track_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698