Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: chrome/browser/ui/panels/panel_browsertest.cc

Issue 11728003: Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding files for gpu_tests and NaCl browser tests. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browsertest.cc
diff --git a/chrome/browser/ui/panels/panel_browsertest.cc b/chrome/browser/ui/panels/panel_browsertest.cc
index 61135e042ede05b3057b802ec35ffb00ff16aa8f..2cf9b7738c32b2a55d4cfbc941b781d8ee39f007 100644
--- a/chrome/browser/ui/panels/panel_browsertest.cc
+++ b/chrome/browser/ui/panels/panel_browsertest.cc
@@ -425,8 +425,8 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DISABLED_AutoResize) {
WaitForAutoResizeWider enlarge(panel);
EXPECT_TRUE(content::ExecuteJavaScript(
panel->GetWebContents()->GetRenderViewHost(),
- std::wstring(),
- L"changeSize(50);"));
+ "",
+ "changeSize(50);"));
enlarge.Wait();
gfx::Rect bounds_on_grow = panel->GetBounds();
EXPECT_GT(bounds_on_grow.width(), initial_bounds.width());
@@ -436,8 +436,8 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DISABLED_AutoResize) {
WaitForAutoResizeNarrower shrink(panel);
EXPECT_TRUE(content::ExecuteJavaScript(
panel->GetWebContents()->GetRenderViewHost(),
- std::wstring(),
- L"changeSize(-30);"));
+ "",
+ "changeSize(-30);"));
shrink.Wait();
gfx::Rect bounds_on_shrink = panel->GetBounds();
EXPECT_LT(bounds_on_shrink.width(), bounds_on_grow.width());
@@ -1566,9 +1566,9 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest,
WaitForAutoResizeWider enlarge(panel);
EXPECT_TRUE(content::ExecuteJavaScript(
panel->GetWebContents()->GetRenderViewHost(),
- std::wstring(),
- L"document.body.innerHTML ="
- L"'<nobr>line of text and a <button>Button</button>';"));
+ "",
+ "document.body.innerHTML ="
+ " '<nobr>line of text and a <button>Button</button>';"));
enlarge.Wait();
// The panel should have become larger in both dimensions (the minimums
« no previous file with comments | « chrome/browser/ui/find_bar/find_bar_host_browsertest.cc ('k') | chrome/browser/ui/webui/bookmarks_ui_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698