Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: chrome/browser/notifications/notification_browsertest.cc

Issue 11728003: Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding files for gpu_tests and NaCl browser tests. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/load_timing_observer_browsertest.cc ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/notification_browsertest.cc
diff --git a/chrome/browser/notifications/notification_browsertest.cc b/chrome/browser/notifications/notification_browsertest.cc
index 54fd6215b0cd5691e690c6595a4e455b46723abd..f4c64715cb7cb0b188f7c032001348d59792aed5 100644
--- a/chrome/browser/notifications/notification_browsertest.cc
+++ b/chrome/browser/notifications/notification_browsertest.cc
@@ -274,8 +274,8 @@ std::string NotificationsTest::CreateNotification(
std::string result;
bool success = content::ExecuteJavaScriptAndExtractString(
browser->tab_strip_model()->GetActiveWebContents()->GetRenderViewHost(),
- L"",
- UTF8ToWide(script),
+ "",
+ script,
&result);
if (success && result != "-1" && wait_for_new_balloon)
success = observer.Wait();
@@ -301,8 +301,8 @@ bool NotificationsTest::RequestPermissionAndWait(Browser* browser) {
std::string result;
bool success = content::ExecuteJavaScriptAndExtractString(
browser->tab_strip_model()->GetActiveWebContents()->GetRenderViewHost(),
- L"",
- L"requestPermission();",
+ "",
+ "requestPermission();",
&result);
if (!success || result != "1")
return false;
@@ -321,8 +321,8 @@ bool NotificationsTest::CancelNotification(
std::string result;
bool success = content::ExecuteJavaScriptAndExtractString(
browser->tab_strip_model()->GetActiveWebContents()->GetRenderViewHost(),
- L"",
- UTF8ToWide(script),
+ "",
+ script,
&result);
if (!success || result != "1")
return false;
@@ -414,8 +414,8 @@ IN_PROC_BROWSER_TEST_F(NotificationsTest, TestUserGestureInfobar) {
bool result;
ASSERT_TRUE(content::ExecuteJavaScriptAndExtractBool(
browser()->tab_strip_model()->GetActiveWebContents()->GetRenderViewHost(),
- L"",
- L"window.domAutomationController.send(request());",
+ "",
+ "window.domAutomationController.send(request());",
&result));
EXPECT_TRUE(result);
« no previous file with comments | « chrome/browser/net/load_timing_observer_browsertest.cc ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698