chrome/browser/extensions/api/web_request/web_request_apitest.cc - Issue 11728003: Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_apitest.cc

Issue 11728003: Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adding files for gpu_tests and NaCl browser tests. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/management_browsertest.cc ('k') | chrome/browser/extensions/app_process_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_apitest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

index cf0d3ba124cffef5d23f9ac9a449635cfdcadba1..ada42b5af530bbcc6de226c73f4dc5625d1ab0e6 100644

--- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

@@ -192,8 +192,9 @@ void ExtensionWebRequestApiTest::RunPermissionTest(

std::string body;

WebContents* tab = chrome::GetActiveWebContents(browser());

ASSERT_TRUE(content::ExecuteJavaScriptAndExtractString(

- tab->GetRenderViewHost(), L"",

- L"window.domAutomationController.send(document.body.textContent)",

+ tab->GetRenderViewHost(),

+ "",

+ "window.domAutomationController.send(document.body.textContent)",

&body));

EXPECT_EQ(expected_content_regular_window, body);

@@ -213,8 +214,9 @@ void ExtensionWebRequestApiTest::RunPermissionTest(

body.clear();

WebContents* otr_tab = chrome::GetActiveWebContents(otr_browser);

ASSERT_TRUE(content::ExecuteJavaScriptAndExtractString(

- otr_tab->GetRenderViewHost(), L"",

- L"window.domAutomationController.send(document.body.textContent)",

+ otr_tab->GetRenderViewHost(),

+ "",

+ "window.domAutomationController.send(document.body.textContent)",

&body));

EXPECT_EQ(exptected_content_incognito_window, body);

}