Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4711)

Unified Diff: chrome/browser/extensions/extension_icon_source_apitest.cc

Issue 11728003: Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding files for gpu_tests and NaCl browser tests. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_icon_source_apitest.cc
diff --git a/chrome/browser/extensions/extension_icon_source_apitest.cc b/chrome/browser/extensions/extension_icon_source_apitest.cc
index 91bdf3b7dd8bbf919e0b72b013037f8157ba7892..e5d4ff0b509b71d917ee6b83228e48d8fda84e4b 100644
--- a/chrome/browser/extensions/extension_icon_source_apitest.cc
+++ b/chrome/browser/extensions/extension_icon_source_apitest.cc
@@ -35,8 +35,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionIconSourceTest, IconsLoaded) {
browser(),
GURL("chrome-extension://gbmgkahjioeacddebbnengilkgbkhodg/index.html"));
ASSERT_TRUE(content::ExecuteJavaScriptAndExtractString(
- chrome::GetActiveWebContents(browser())->GetRenderViewHost(), L"",
- L"window.domAutomationController.send(document.title)",
+ chrome::GetActiveWebContents(browser())->GetRenderViewHost(),
+ "",
+ "window.domAutomationController.send(document.title)",
&result));
EXPECT_EQ(result, "Loaded");
@@ -46,8 +47,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionIconSourceTest, IconsLoaded) {
browser(),
GURL("chrome-extension://apocjbpjpkghdepdngjlknfpmabcmlao/index.html"));
ASSERT_TRUE(content::ExecuteJavaScriptAndExtractString(
- chrome::GetActiveWebContents(browser())->GetRenderViewHost(), L"",
- L"window.domAutomationController.send(document.title)",
+ chrome::GetActiveWebContents(browser())->GetRenderViewHost(),
+ "",
+ "window.domAutomationController.send(document.title)",
&result));
EXPECT_EQ(result, "Not Loaded");
}
@@ -66,8 +68,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionIconSourceTest, IconsLoadedIncognito) {
browser()->profile(),
GURL("chrome-extension://gbmgkahjioeacddebbnengilkgbkhodg/index.html"));
ASSERT_TRUE(content::ExecuteJavaScriptAndExtractString(
- chrome::GetActiveWebContents(otr_browser)->GetRenderViewHost(), L"",
- L"window.domAutomationController.send(document.title)",
+ chrome::GetActiveWebContents(otr_browser)->GetRenderViewHost(),
+ "",
+ "window.domAutomationController.send(document.title)",
&result));
EXPECT_EQ(result, "Loaded");
@@ -77,8 +80,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionIconSourceTest, IconsLoadedIncognito) {
browser()->profile(),
GURL("chrome-extension://apocjbpjpkghdepdngjlknfpmabcmlao/index.html"));
ASSERT_TRUE(content::ExecuteJavaScriptAndExtractString(
- chrome::GetActiveWebContents(otr_browser)->GetRenderViewHost(), L"",
- L"window.domAutomationController.send(document.title)",
+ chrome::GetActiveWebContents(otr_browser)->GetRenderViewHost(),
+ "",
+ "window.domAutomationController.send(document.title)",
&result));
EXPECT_EQ(result, "Not Loaded");
}
« no previous file with comments | « chrome/browser/extensions/extension_dom_clipboard_apitest.cc ('k') | chrome/browser/extensions/extension_incognito_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698