chrome/browser/extensions/extension_nacl_browsertest.cc - Issue 11728003: Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_nacl_browsertest.cc

Issue 11728003: Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adding files for gpu_tests and NaCl browser tests. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_keybinding_apitest.cc ('k') | chrome/browser/extensions/extension_resource_request_policy_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_nacl_browsertest.cc

diff --git a/chrome/browser/extensions/extension_nacl_browsertest.cc b/chrome/browser/extensions/extension_nacl_browsertest.cc

index 3e910ac6987d06394f63c5762f977bf1ba5c54c3..2939278be3f781b3cf4de7b471bebe150f6e39d7 100644

--- a/chrome/browser/extensions/extension_nacl_browsertest.cc

+++ b/chrome/browser/extensions/extension_nacl_browsertest.cc

@@ -103,12 +103,14 @@ class NaClExtensionTest : public ExtensionBrowserTest {

bool content_handler_plugin_created = false;

WebContents* web_contents = chrome::GetActiveWebContents(browser());

ASSERT_TRUE(content::ExecuteJavaScriptAndExtractBool(

- web_contents->GetRenderViewHost(), L"",

- L"window.domAutomationController.send(EmbeddedPluginCreated());",

+ web_contents->GetRenderViewHost(),

+ "",

+ "window.domAutomationController.send(EmbeddedPluginCreated());",

&embedded_plugin_created));

ASSERT_TRUE(content::ExecuteJavaScriptAndExtractBool(

- web_contents->GetRenderViewHost(), L"",

- L"window.domAutomationController.send(ContentHandlerPluginCreated());",

+ web_contents->GetRenderViewHost(),

+ "",

+ "window.domAutomationController.send(ContentHandlerPluginCreated());",

&content_handler_plugin_created));

EXPECT_EQ(should_create, embedded_plugin_created);