Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1665)

Unified Diff: content/browser/session_history_browsertest.cc

Issue 11728003: Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding files for gpu_tests and NaCl browser tests. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/session_history_browsertest.cc
diff --git a/content/browser/session_history_browsertest.cc b/content/browser/session_history_browsertest.cc
index 232ad17756af2b481d956546eabe6cd87f887606..c81f89c0830b936b24722cda3b2f348a5dd52589 100644
--- a/content/browser/session_history_browsertest.cc
+++ b/content/browser/session_history_browsertest.cc
@@ -431,14 +431,18 @@ IN_PROC_BROWSER_TEST_F(SessionHistoryTest, HistoryLength) {
int length;
ASSERT_TRUE(ExecuteJavaScriptAndExtractInt(
shell()->web_contents()->GetRenderViewHost(),
- L"", L"domAutomationController.send(history.length)", &length));
+ "",
+ "domAutomationController.send(history.length)",
+ &length));
EXPECT_EQ(1, length);
NavigateToURL(shell(), GetURL("title1.html"));
ASSERT_TRUE(ExecuteJavaScriptAndExtractInt(
shell()->web_contents()->GetRenderViewHost(),
- L"", L"domAutomationController.send(history.length)", &length));
+ "",
+ "domAutomationController.send(history.length)",
+ &length));
EXPECT_EQ(2, length);
// Now test that history.length is updated when the navigation is committed.
@@ -446,7 +450,9 @@ IN_PROC_BROWSER_TEST_F(SessionHistoryTest, HistoryLength) {
ASSERT_TRUE(ExecuteJavaScriptAndExtractInt(
shell()->web_contents()->GetRenderViewHost(),
- L"", L"domAutomationController.send(history.length)", &length));
+ "",
+ "domAutomationController.send(history.length)",
+ &length));
EXPECT_EQ(3, length);
GoBack();
@@ -457,7 +463,9 @@ IN_PROC_BROWSER_TEST_F(SessionHistoryTest, HistoryLength) {
ASSERT_TRUE(ExecuteJavaScriptAndExtractInt(
shell()->web_contents()->GetRenderViewHost(),
- L"", L"domAutomationController.send(history.length)", &length));
+ "",
+ "domAutomationController.send(history.length)",
+ &length));
EXPECT_EQ(2, length);
}

Powered by Google App Engine
This is Rietveld 408576698